fix(market-installer): ensure bundled Node and pnpm runtimes are used for plugin installation - #61
Merged
Merged
Conversation
… for plugin installation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm: 10.34.5directly to rootpackage.jsondependencies to ensure it is always included in the packaged Electron distribution.ensurePnpmShiminpackages/dsh-desktop-market-installerto generate shims for bothpnpmandnode(supporting.cmdon Windows and executable shell scripts on POSIX), pointing directly to the app's bundled Node runtime (process.execPath)..desktop-bindirectory and the bundled Node runtime directory toPATH(handling WindowsPath/PATHcase differences), guaranteeing that any plugin install or subprocess runs with the bundled runtimes without requiring a system Node.js install.test/market-installer.test.jsto verify that bothnodeandpnpmshims are properly generated.