Skip to content

replaced determine_report & persist_results with new interface report… - #125

Merged
tombonfert merged 1 commit into
mainfrom
fix/custom_db_report_api
Oct 15, 2026
Merged

tombonfert merged 1 commit into
mainfrom
fix/custom_db_report_api

Conversation

@adefabian

@adefabian adefabian commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Switched to new report api run.

Changes

  • replaced report.determine_report() & report.persist() with report.run*(

Test Plan

  • Unit tests added/updated
  • Manual testing completed
  • Documentation updated (if applicable)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No new linter warnings introduced

@adefabian
adefabian marked this pull request as ready for review October 15, 2026 12:26
@adefabian
adefabian requested a review from a team as a code owner October 15, 2026 12:26
@adefabian
adefabian requested a review from tombonfert October 15, 2026 12:26
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (be3ea0b) to head (974a4a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          68       68           
  Lines        6068     6068           
  Branches      758      758           
=======================================
  Hits         5480     5480           
  Misses        466      466           
  Partials      122      122           
Flag Coverage Δ
query_engine 86.80% <ø> (ø)
reporting 94.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tombonfert tombonfert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombonfert
tombonfert merged commit 8fa2124 into main Oct 15, 2026
8 of 10 checks passed
@tombonfert
tombonfert deleted the fix/custom_db_report_api branch October 15, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants