Skip to content

fix(key-wallet): wipe mnemonic phrase copies in the FFI and bincode decoding - #1271

Merged
ZocoLini merged 2 commits into
devfrom
pasta/ffi-mnemonic-wipe
Nov 1, 2026
Merged

ZocoLini merged 2 commits into
devfrom
pasta/ffi-mnemonic-wipe

fix(key-wallet): wipe the bytes of an invalid UTF-8 mnemonic phrase i…

950b6e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2026 in 0s

80.96% (+0.22%) compared to af5f267

View this Pull Request on Codecov

80.96% (+0.22%) compared to af5f267

Details

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.96%. Comparing base (af5f267) to head (950b6e6).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
key-wallet-ffi/src/mnemonic.rs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1271      +/-   ##
==========================================
+ Coverage   80.73%   80.96%   +0.22%     
==========================================
  Files         291      291              
  Lines       77783    77812      +29     
==========================================
+ Hits        62801    62998     +197     
+ Misses      14982    14814     -168     
Files with missing lines Coverage Δ
key-wallet/src/mnemonic.rs 99.57% <100.00%> (+1.03%) ⬆️
key-wallet-ffi/src/mnemonic.rs 72.05% <75.00%> (+25.60%) ⬆️

... and 20 files with indirect coverage changes