Skip to content

perf(dash-spv)!: persist the masternode list engine instead of replaying its messages - #1221

Merged
xdustinface merged 2 commits into
devfrom
perf/masternode-engine-snapshot
Oct 28, 2026
Merged

xdustinface merged 2 commits into
devfrom
perf/masternode-engine-snapshot

fix(dash-spv): truncate the engine even when storage truncation fails…

ebe1fa3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 26, 2026 in 0s

78.79% (-0.09%) compared to 22f52ac

View this Pull Request on Codecov

78.79% (-0.09%) compared to 22f52ac

Details

Codecov Report

❌ Patch coverage is 93.22034% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.79%. Comparing base (22f52ac) to head (ebe1fa3).

Files with missing lines Patch % Lines
dash-spv/src/client/queries.rs 0.00% 6 Missing ⚠️
dash-spv/src/storage/masternode.rs 97.70% 3 Missing ⚠️
dash-spv/src/sync/masternodes/manager.rs 77.77% 2 Missing ⚠️
dash-spv/src/sml_engine.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1221      +/-   ##
==========================================
- Coverage   78.88%   78.79%   -0.09%     
==========================================
  Files         304      305       +1     
  Lines       81331    81004     -327     
==========================================
- Hits        64155    63830     -325     
+ Misses      17176    17174       -2     
Files with missing lines Coverage Δ
dash-spv/src/client/core.rs 60.86% <ø> (+2.04%) ⬆️
dash-spv/src/client/lifecycle.rs 90.87% <100.00%> (-0.04%) ⬇️
dash-spv/src/storage/migrator/mod.rs 39.28% <ø> (ø)
dash-spv/src/storage/migrator/v3.rs 100.00% <100.00%> (ø)
dash-spv/src/storage/mod.rs 90.25% <100.00%> (+1.02%) ⬆️
dash-spv/src/sync/masternodes/sync_manager.rs 98.78% <100.00%> (-0.08%) ⬇️
dash-spv/src/sml_engine.rs 97.23% <95.45%> (-0.03%) ⬇️
dash-spv/src/sync/masternodes/manager.rs 96.44% <77.77%> (-0.59%) ⬇️
dash-spv/src/storage/masternode.rs 98.23% <97.70%> (-1.33%) ⬇️
dash-spv/src/client/queries.rs 42.50% <0.00%> (-1.05%) ⬇️

... and 5 files with indirect coverage changes