chore: bump rust-dashcore to the latest dev revision - #4394
Conversation
Moves all eight rust-dashcore workspace pins from 36b49cb7 to 173ffac0, the current head of the dev branch. The single commit in that range is the key rotation ChainLock signature fix, which keys each rotated quorum's quarter signatures to its own cycle work block instead of collapsing them to one signature per diff. Without it a fresh mainnet sync could hard-fail a QRInfo feed and permanently wedge masternode sync, ChainLock validation and InstantSend verification. The change is internal to the masternode list engine and dash-spv; no platform crate calls the surface it reshapes. Co-Authored-By: Claude Opus 5 <[email protected]>
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
|
ℹ️ Review superseded (commit fa6aaec) |
Issue being fixed or feature implemented
Moves the workspace's rust-dashcore pins up to the current head of
dev, picking up the key rotation ChainLock signature fix (rust-dashcore#934).That fix matters for us:
feed_qr_infowas collapsing each diff'squorumsCLSigsdown to a single signature taken from the first rotating quorum it saw, then stamping the same 4-signature tuple onto every entry of the batch. The active rotation set can span several cycles at once, because a failed DKG leaves the previous cycle's quorum in place at that index, so every straggler got quarter modifiers built from another cycle's signatures. The reconstructed member sets then disagreed with the real signers and the whole QRInfo hard-failed withAllCommitmentAggregatedSignatureNotValidon the first fresh-sync response — permanently wedging masternode sync, ChainLock validation and InstantSend verification.What was done?
Bumped all eight rust-dashcore workspace pins from
36b49cb7to173ffac0and regenerated the affectedCargo.lockentries.Cargo.tomlandCargo.lockare the only files touched; both pin sites are workspace-level (packages/rs-platform-walletonly inherits viaworkspace = true), and no stale revisions remain anywhere in the tree.The range is exactly one upstream commit. Alongside the signature keying it hardens several peer-controlled inputs in the same paths — an out-of-range
quorum_indexthat sign-extended and underflowed the cycle base, a truncatedlastCommitmentPerIndexthat passed the trust gate, and whole-map cycle replacement that let one genuine commitment drop the other indices of a stored cycle. It also degrades individual quorums toSkippedrather than poisoning an entire feed when context is missing.No platform source changes were needed. The reshaped surface —
QRInfoFeedResult's new fields,find_rotated_masternodes_for_quorumsreturning a per-quorumResult, the newQuorumValidationErrorvariants and the newqrinfo-capturefeature — has zero call sites in this repo; every consumer lives inside rust-dashcore and dash-spv.How Has This Been Tested?
cargo check --workspace --all-targets— cleancargo check --workspace --all-features --all-targets— cleancargo test -p dpp --all-features— 3955 passed, 0 failedcargo test -p drive-abci --lib— 2670 passed, 1 failedThe single
drive-abcifailure is pre-existing and unrelated to this bump.test_data_contract_creation_fails_with_more_than_fifty_keywordsfails withconfig version 0 is not supported, minimum version is 1; it passes in isolation, and the identical suite run against the base pin36b49cb7fails on the same test with the same counts (2670 passed / 1 failed). It is the latentPlatformVersion::set_currentglobal test race — a concurrent test resets the global version mid-run and the contract serializes at config v0. Worth fixing, but separately from this bump.Breaking Changes
None. No consensus-relevant platform behavior changes; the upstream fix corrects quorum reconstruction that previously failed outright.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code