Skip to content

fix: snapshot CoinJoin collaterals before random fee charging #7598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 1 commit into from
Aug 13, 2026
Merged

fix: snapshot CoinJoin collaterals before random fee charging #7598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/coinjoin/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,15 @@ void CCoinJoinServer::ChargeFees() const
*/
void CCoinJoinServer::ChargeRandomFees() const
{
for (const auto& txCollateral : vecSessionCollaterals) {
AssertLockNotHeld(cs_coinjoin);

std::vector<CTransactionRef> session_collaterals;
{
LOCK(cs_coinjoin);
session_collaterals = vecSessionCollaterals;
}

for (const auto& txCollateral : session_collaterals) {
if (GetRand<int>(/*nMax=*/100) > 10) return;
LogPrint(BCLog::COINJOIN, /* Continued */
"CCoinJoinServer::ChargeRandomFees -- charging random fees, txCollateral=%s", txCollateral->ToString());
Expand Down
2 changes: 1 addition & 1 deletion src/coinjoin/server.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class CCoinJoinServer : public CCoinJoinBaseSession, public NetHandler
/// Charge fees to bad actors (Charge clients a fee if they're abusive)
void ChargeFees() const EXCLUSIVE_LOCKS_REQUIRED(!cs_coinjoin);
/// Rarely charge fees to pay miners
void ChargeRandomFees() const;
void ChargeRandomFees() const EXCLUSIVE_LOCKS_REQUIRED(!cs_coinjoin);
/// Consume collateral in cases when peer misbehaved
void ConsumeCollateral(const CTransactionRef& txref) const;

Expand Down
Loading