Skip to content

docs: drop stale project-stack references from stack-docs wording - #421

Merged
danibsheehan merged 1 commit into
mainfrom
docs/stack-docs-wording
Oct 12, 2026
Merged

danibsheehan merged 1 commit into
mainfrom
docs/stack-docs-wording

Conversation

@danibsheehan

Copy link
Copy Markdown
Owner

Summary

  • Why: four places still described make check-stack-docs as checking a project-stack / project-stack.mdc file. That file doesn't exist (Cursor rule files were removed), and the script only validates README.md and AGENTS.md against the manifests, so the wording misleads anyone reading the Makefile, README or script.
  • What: one-line wording fixes in the Makefile comment, the README make table, an AGENTS.md constraint, and the check_stack_docs.py docstring. They now name what the script really checks: README and AGENTS.md against package.json, go.mod, .nvmrc, the Dockerfile Go tag and workflows. No logic changes.
  • Follow-up to ci: single-source the Go version from go.mod, guard the Dockerfile pin #417 and docs(skills): fix stale CI facts in four skills #420; this finishes the stale-wording cleanup.

How to verify

Docs-only; no code or behavior change.

  • grep -rn "project-stack" --exclude-dir=node_modules --exclude-dir=.git . returns nothing.
  • make check-stack-docs and make check-skills-docs pass.

🤖 Generated with Claude Code

check_stack_docs.py validates README and AGENTS.md against the manifests,
the Dockerfile and workflows. There is no project-stack.mdc (Cursor rules
files were removed), but the script docstring, Makefile comment, README
table and an AGENTS.md constraint still named it. Wording only, no logic.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions

Copy link
Copy Markdown
Contributor

PR guide

Auto-generated from changed paths. Prefer a why-first Summary in the PR description above (motivation, then what changed); use this comment for path-based checklist and suggested verify commands.

Touches: CI / GitHub, docs, other

Diff: 4 files changed, 4 insertions(+), 4 deletions(-)

Suggested verify

  • N/A — tooling/docs only; confirm locally if anything user-facing changed

Checklist (applies to this PR)

  • No unintended secrets or local-only config committed

Reviewer focus

  • Workflow changes and required status check names

Commits

  • d55cac4 docs: drop stale project-stack references from stack-docs wording

Files by area

Area Files
CI / GitHub 1
docs 1
other 2

CI

Required checks: Frontend (per-concern jobs) and Backend in verify. Coverage tables are posted separately when those jobs finish.


Template: pull_request_template.md

@github-actions

Copy link
Copy Markdown
Contributor

frontend

File Coverage Lines Branches
All files 86% 94% 79% ✅
src/api/client.ts 98% 98% 97% ✅
src/components/charts/DivisionRunsScatter.tsx 85% 95% 75% ✅
src/components/charts/GamePitcherStrikeZones.tsx 81% 86% 75% ✅
src/components/charts/GameScoreBar.tsx 86% 90% 82% ✅
src/components/charts/GameStatcastScatter.tsx 76% 86% 65% ❌
src/components/charts/GameStatcastSpray.tsx 83% 98% 69% ✅
src/components/charts/LeadersTop10Bar.tsx 88% 100% 76% ✅
src/components/charts/MultiTeamWinPctChart.tsx 62% 75% 49% ❌
src/components/charts/PlayerCompareAheadChart.tsx 92% 95% 90% ✅
src/components/charts/PlayerCompareCareerLines.tsx 74% 88% 60% ❌
src/components/charts/PlayerComparePlatoonBars.tsx 44% 52% 35% ❌
src/components/charts/PlayerCompareRecentSparklines.tsx 72% 88% 55% ❌
src/components/charts/PlayerCompareStatsTable.tsx 88% 93% 83% ✅
src/components/charts/PlayerRadar.tsx 97% 100% 94% ✅
src/components/charts/RecordTimelineStrip.tsx 86% 85% 86% ✅
src/components/charts/TeamSeasonDeepDive.tsx 91% 100% 83% ✅
src/components/charts/TeamWinsBarChart.tsx 68% 92% 44% ❌
src/components/charts/WinLossChart.tsx 87% 82% 91% ✅
src/components/game/BoxscoreSortableTable.tsx 95% 100% 91% ✅
src/components/game/GameBoxscorePanel.tsx 67% 94% 39% ❌
src/components/ui/PlayerCard.tsx 75% 100% 50% ❌
src/components/ui/PlayerPicker.tsx 98% 100% 96% ✅
src/components/ui/index.ts 0% 0% 0% ❌
src/data/parkSprayOutline.ts 83% 100% 66% ✅
src/hooks/useAsyncResource.ts 95% 100% 91% ✅
src/hooks/useGameDetailData.ts 75% 100% 50% ❌
src/hooks/useGameTimeline.ts 85% 83% 87% ✅
src/hooks/usePlayerCompareChartColors.ts 94% 92% 96% ✅
src/hooks/useRecordTimeline.ts 81% 80% 83% ✅
src/pages/GameDetail.tsx 95% 100% 90% ✅
src/pages/GamesSlate.tsx 98% 100% 97% ✅
src/pages/Leaders.tsx 91% 97% 84% ✅
src/pages/PlayerComparison.tsx 87% 91% 83% ✅
src/pages/Standings.tsx 78% 86% 69% ✅
src/pages/TeamOverview.tsx 83% 93% 73% ✅
src/utils/chartColorContrast.ts 92% 98% 87% ✅
src/utils/gameChartColors.ts 84% 96% 72% ✅
src/utils/gameStatcastPitchers.ts 88% 100% 77% ✅
src/utils/leadersBarData.ts 90% 100% 80% ✅
src/utils/mlbTeamColors.ts 83% 88% 78% ✅
src/utils/mlbTeamObsidianRegistry.ts 92% 100% 84% ✅
src/utils/pitchTypeColors.ts 88% 97% 79% ✅
src/utils/pitchZoneHeatmap.ts 97% 100% 95% ✅
src/utils/playerCompareCareerRows.ts 83% 100% 66% ✅
src/utils/playerCompareMetricRows.ts 92% 100% 85% ✅
src/utils/playerCompareSearchParams.ts 94% 96% 93% ✅
src/utils/playerPlatoonBarRows.ts 89% 100% 78% ✅
src/utils/recordTimelineCalendar.ts 96% 100% 93% ✅
src/utils/recordTimelineChart.ts 81% 94% 67% ✅
src/utils/statcastDisplay.ts 85% 93% 77% ✅
src/utils/statcastPlateNormalized.ts 89% 95% 83% ✅
src/utils/teamOverviewSearchParams.ts 96% 100% 92% ✅
src/utils/yearByYearMetric.ts 96% 100% 92% ✅

Minimum allowed coverage is 78%

Generated by 🐒 cobertura-action against d55cac4

@github-actions

Copy link
Copy Markdown
Contributor

backend

File Coverage Lines Branches
All files 85% 85% 0% ✅
apidocs/handler.go 0% 0% 0% ❌
cmd/e2e-upstream/main.go 0% 0% 0% ❌
config/config.go 75% 75% 0% ✅
handlers/cache_ttl.go 100% 100% 0% ✅
handlers/divisions.go 100% 100% 0% ✅
handlers/fetch_pair.go 100% 100% 0% ✅
handlers/game_boxscore.go 89% 89% 0% ✅
handlers/game_schedule.go 100% 100% 0% ✅
handlers/game_statcast.go 97% 97% 0% ✅
handlers/game_statcast_pitches.go 95% 95% 0% ✅
handlers/game_timeline.go 85% 85% 0% ✅
handlers/games_for_date.go 82% 82% 0% ✅
handlers/handlers.go 100% 100% 0% ✅
handlers/json_response.go 90% 90% 0% ✅
handlers/leaders.go 89% 89% 0% ✅
handlers/league_season_baseline.go 91% 91% 0% ✅
handlers/mlb_schedule.go 100% 100% 0% ✅
handlers/player_current_team.go 64% 64% 0% ❌
handlers/player_search.go 89% 89% 0% ✅
handlers/players_compare.go 88% 88% 0% ✅
handlers/players_compare_platoon.go 71% 71% 0% ✅
handlers/players_compare_trends.go 78% 78% 0% ✅
handlers/query_params.go 100% 100% 0% ✅
handlers/record_timeline.go 83% 83% 0% ✅
handlers/record_timelines_batch.go 88% 88% 0% ✅
handlers/standings.go 91% 91% 0% ✅
handlers/stat_coerce.go 100% 100% 0% ✅
handlers/team_season_schedule.go 100% 100% 0% ✅
handlers/team_season_stats.go 97% 97% 0% ✅
handlers/team_season_venue.go 89% 89% 0% ✅
handlers/teams.go 75% 75% 0% ✅
handlers/upstream_error.go 90% 90% 0% ✅
internal/e2eupstream/chaos.go 70% 70% 0% ✅
internal/e2eupstream/upstream.go 76% 76% 0% ✅
main.go 0% 0% 0% ❌
router.go 100% 100% 0% ✅
middleware/cors.go 100% 100% 0% ✅
middleware/logger.go 97% 97% 0% ✅
middleware/max_body_bytes.go 100% 100% 0% ✅
middleware/ratelimit.go 100% 100% 0% ✅
middleware/request_id_header.go 100% 100% 0% ✅
services/cache.go 78% 78% 0% ✅
services/metrics.go 83% 83% 0% ✅
services/mlb_client.go 88% 88% 0% ✅
services/savant_client.go 100% 100% 0% ✅
services/upstream_http.go 78% 78% 0% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against d55cac4

@danibsheehan
danibsheehan merged commit 9c8b0ff into main Oct 12, 2026
25 checks passed
@danibsheehan
danibsheehan deleted the docs/stack-docs-wording branch October 12, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant