Repository navigation
docs(skills): drop stale ci.yml references from doc-sync-patch - #419
Merged
Merged
Conversation
The skill's description and anti-patterns still named .github/workflows/ci.yml, which doesn't exist. Point at backend/Dockerfile instead, which check_stack_docs.py now reads alongside go.mod and .nvmrc. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
PR guideAuto-generated from changed paths. Prefer a why-first Summary in the PR description above (motivation, then what changed); use this comment for path-based checklist and suggested verify commands. Touches: other Diff: 1 file changed, 2 insertions(+), 2 deletions(-) Suggested verify
Checklist (applies to this PR)
Reviewer focus
Commits
Files by area
CIRequired checks: Frontend (per-concern jobs) and Backend in verify. Coverage tables are posted separately when those jobs finish. Template: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc-sync-patchskill's description (which decides when the skill triggers) and its anti-patterns still named.github/workflows/ci.yml, a file that doesn't exist. After ci: single-source the Go version from go.mod, guard the Dockerfile pin #417 the Go version also no longer lives in a workflow, so the pointer was doubly wrong..claude/skills/doc-sync-patch/SKILL.mdnow point atbackend/Dockerfile, whichcheck_stack_docs.pyreads alongsidego.modand.nvmrc.ci.ymlreference in theadr-doc-sync-check,openapi-maintainandlocal-ci-parityskills. Those need their own check, since the right replacement may not beverify.yml(some steps live in the shareddani-actionsworkflow).How to verify
Docs-only; no code or behavior change.
make check-skills-docsandmake check-stack-docspass.grep -n "ci\.yml" .claude/skills/doc-sync-patch/SKILL.mdreturns nothing.🤖 Generated with Claude Code