Repository navigation
docs(openspec): plan #3972 Require perimeter tests in a manifest plan - #4138
Draft
devops-cli-service[bot] wants to merge 1 commit into
Draft
devops-cli-service[bot] wants to merge 1 commit into
devops-cli-service[bot] wants to merge 1 commit into
Conversation
devops-cli-service
Bot
added
type/docs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plans #3972
The stage job refuses a plan that changes a YAML manifest under
k8s/and leaves out a test file that references it. Without that test inChanges:, the implement runner cannot edit it, becausediff_scopeforbids a change outside the plan, so it loops until it spends its token budget and the item stops blocked. The job records the tests that each changed manifest reaches before it judges the reply, and the plan check reads that record. A test counts as a reference when it holds the manifest file name and the name of the manifest's folder. The merged-plan recheck records the same thing at its commit, and the replay reads the record from its case.Change:
openspec/changes/3972-stage-includes-perimeter-tests-for-network/