Repository navigation
fix(k8s): check example ConfigMap keys are settings - #4134
Merged
Merged
Conversation
Owner
Author
|
Test record for #4093. fail-to-pass (
Full Rollout: this change removes, renames and tightens no setting, so the live ConfigMap needs no change. Nothing was applied to the cluster. |
dan-petty
marked this pull request as ready for review
November 8, 2026 04:41
dan-petty
pushed a commit
that referenced
this pull request
Nov 8, 2026
🤖 I have created a release *beep* *boop* --- ## [0.87.2](v0.87.1...v0.87.2) (2026-11-08) ### Bug Fixes * **k8s:** check example ConfigMap keys are settings ([7935fba](7935fba)) * **k8s:** check example ConfigMap keys are settings ([#4134](#4134)) ([7935fba](7935fba)) * **roadmap:** write the body with the marks in one request ([#4130](#4130)) ([9504170](9504170)) * **service:** show a state record the Service could not write ([#4128](#4128)) ([cd2ebda](cd2ebda)), closes [#4048](#4048) ### Code Refactoring * **roadmap:** type the stage planner request ([#4124](#4124)) ([d83491e](d83491e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: dan-petty-release[bot] <346998822+dan-petty-release[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(k8s): check example ConfigMap keys are settings
A new test walks the keys of the example ConfigMap and reports each key that no setting declares. Most models of Settings use extra=ignore, so such a key loaded with no error before. Two rules now say that a change which removes, renames or tightens a setting must say so in the proposal and the PR comment, and must load the example ConfigMap into Settings in a test. The live ConfigMap changes first. This follows the crash of the roadmap Service on 2026-11-07, when the live ConfigMap still held two removed ladder keys.
Closes #4093
Change:
openspec/changes/archive/2026-11-08-4093-check-example-configmap-keys-are-settings/Elapsed: 1.58s