Skip to content

fix(roadmap): write the body with the marks in one request - #4130

Merged
dan-petty merged 5 commits into
mainfrom
fix/4049-one-write-body-and-marks
Nov 8, 2026
Merged

dan-petty merged 5 commits into
mainfrom
fix/4049-one-write-body-and-marks

Conversation

@dan-petty

Copy link
Copy Markdown
Owner

Refine and the alternatives check wrote one result with two requests: the body, then the marks. A stop between them left the new body with the old marks. The next round read the new body as a person's edit and refined the item again, with model spend. The alternatives check looked unchecked and ran again. set_field and set_marks now take an optional body, and the GitHub store sends the body, the labels and the job record in one PATCH. Refine and the alternatives check no longer call write_issue_body for a result. Repair keeps it. The dry-run plan lists one request less. No setting changes.

Closes #4049

Change: openspec/changes/archive/2026-11-08-4049-one-write-body-and-marks/
Elapsed: 3.97s

@dan-petty dan-petty added type/bug Defect, regression, or incorrect runtime behavior scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them labels Nov 8, 2026
@dan-petty

Copy link
Copy Markdown
Owner Author

Test record for #4049.

Fail-to-pass: uv run devops ci fail-to-pass --base origin/main ran in the tests stage. 13 tests failed on base and 86 passed. The 13 include all five criteria of the issue (refine write of a Ready item, a New item and a marks-only item; the alternatives write; the store body with marks). The tests are in tests/roadmap/refine/test_roadmap_refine_one_write.py, tests/roadmap/test_roadmap_alternatives_one_write.py, tests/roadmap/stores/test_roadmap_store_body_with_marks.py and tests/roadmap/test_roadmap_dry_runs.py.

Full uv run devops ci ran once, under the shared lock. One failure was mine: the alternatives rate-limit test injected its fault on write_issue_body. Fixed in f7db2b3 and the file passes. The coverage row failed only because the test row failed. The slow test row (13 minutes) is the known #3593. All other rows passed. After that run the branch was rebased onto origin/main 95f37d4 and the change was archived. The rebase touched only SearXNG tests and specs. The 66 tests of the five change test files pass again, and docs generate --check and openspec check pass. The full CI run was not repeated on the rebased tree; the CI checks of this pull request cover it.

Rollout rule: the change adds, removes, renames or tightens no setting. k8s/devops/configmap.example.yaml and the live ConfigMap are not touched, so no ConfigMap-load test is needed. Nothing was applied to the cluster.

@dan-petty
dan-petty marked this pull request as ready for review November 8, 2026 04:27
@dan-petty
dan-petty merged commit 9504170 into main Nov 8, 2026
25 checks passed
@dan-petty
dan-petty deleted the fix/4049-one-write-body-and-marks branch November 8, 2026 04:41
dan-petty pushed a commit that referenced this pull request Nov 8, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.87.2](v0.87.1...v0.87.2)
(2026-11-08)


### Bug Fixes

* **k8s:** check example ConfigMap keys are settings
([7935fba](7935fba))
* **k8s:** check example ConfigMap keys are settings
([#4134](#4134))
([7935fba](7935fba))
* **roadmap:** write the body with the marks in one request
([#4130](#4130))
([9504170](9504170))
* **service:** show a state record the Service could not write
([#4128](#4128))
([cd2ebda](cd2ebda)),
closes [#4048](#4048)


### Code Refactoring

* **roadmap:** type the stage planner request
([#4124](#4124))
([d83491e](d83491e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: dan-petty-release[bot] <346998822+dan-petty-release[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them type/bug Defect, regression, or incorrect runtime behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(roadmap): write the item body and its marks in one request

1 participant