fix: UpdateEditorConfig condition for single-targeting projects#490
Conversation
… projects The condition compared IsCrossTargetingProject to IsCrossTargetingBuild, but the latter is undefined on normal single-targeting builds, so the target never ran for the common case. The condition now explicitly handles both single- and cross-targeting builds.
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughChangesEditorConfig target gating
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 16 16
Branches 1 1
=========================================
Hits 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
UpdateEditorConfig's condition comparedIsCrossTargetingProjecttoIsCrossTargetingBuild; the latter is undefined on normal single-targeting builds, so the target never ran for the common case (singleTargetFrameworkprojects). Condition rewritten to explicitly handle both single- and cross-targeting builds.Test plan
.editorconfigcopied, and a cross-targeting inner build does not re-run the copy.Summary by CodeRabbit
Bug Fixes
Tests