Skip to content

chore: drop banned typecheck paths and fix broken npm scripts #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daggerstuff merged 7 commits into from
Nov 1, 2026
Merged

chore: drop banned typecheck paths and fix broken npm scripts #6452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a8f0bed
chore: drop banned typecheck paths and fix broken npm scripts
cursoragent Oct 31, 2026
fcaeb03
chore: restore pnpm-lock.yaml (no lockfile changes in this PR)
cursoragent Oct 31, 2026
5f94b7a
Merge remote-tracking branch 'origin/staging' into cursor-6452
daggerstuff Nov 1, 2026
b801b47
fix(deps): remove @astrojs/check after dropping typecheck scripts
daggerstuff Nov 1, 2026
aca72bf
fix: address review threads (readiness lint lane, localhost binding, …
daggerstuff Nov 1, 2026
b375ab9
Merge branch 'staging' into cursor/drop-banned-typecheck-fix-scripts-…
daggerstuff Nov 1, 2026
b5d5ef9
Merge branch 'staging' into cursor/drop-banned-typecheck-fix-scripts-…
daggerstuff Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Devcontainer: the only outright zero on the readiness report.
// Matches the documented toolchain exactly: Node 24 + pnpm 11.24
// Matches the documented toolchain exactly: Node 24 + pnpm 12.16.1
// (packageManager pin), Python 3.14 via uv (ai/ requires-python),
// and docker-outside-of-docker for the throwaway pe test database
// (make pe-test-db). Submodules are checked out by the post-create
Expand Down
5 changes: 2 additions & 3 deletions GEMINI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ Python):
# Frontend & Services (Astro 6 / React 19 / Express)
pnpm dev # Start Astro frontend (port 5173)
pnpm dev:all-services # Start complete local service ecosystem
pnpm typecheck # Run TypeScript compiler checks
pnpm lint # ESLint & formatting audits
pnpm lint # oxlint (type-aware) and repo lint gates
pnpm vitest run -c config/vitest.config.ts # Run unit/integration tests
pnpm build # Production build

Expand Down Expand Up @@ -92,6 +91,6 @@ uv run python -m <pkg> # Run Python module
1. **Grounded Approach**: Confirm understanding against Foresight context.
2. **Minimal-Safe Edits**: Implement surgical code changes.
3. **Targeted Verification**: Run tests (`pnpm vitest`, `uv run pytest`) and
linting (`pnpm typecheck`).
linting (`pnpm lint`).
4. **State Capture**: Update `pending_items` or store new decisions in Foresight
before closing.
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ format: ## Format all code
format-check: ## Check formatting
pnpm format:check

typecheck: ## Run TypeScript type check
pnpm typecheck
typecheck: ## Run oxlint type-aware lint (see AGENTS.md — no tsc/astro check)
pnpm lint

check-all: ## Run all checks (typecheck + lint + format)
pnpm check:all
check-all: ## Run lint gates (formerly check:all; typecheck scripts removed)
pnpm lint

# ── Docker ──────────────────────────────────────────────

Expand Down
3 changes: 1 addition & 2 deletions apps/web/src/content-store/docs/development-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ pnpm run diagnostics

## Additional Development Tools

- **Code Linting**: `pnpm lint`
- **Type Checking**: `pnpm typecheck`
- **Code Linting**: `pnpm lint` (oxlint, type-aware)
- **Testing**: `pnpm test`
- **Formatting**: `pnpm format`
3 changes: 1 addition & 2 deletions apps/web/src/content-store/docs/getting-started/setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ pnpm run diagnostics

## Additional Development Tools

- **Code Linting**: `pnpm lint`
- **Type Checking**: `pnpm typecheck`
- **Code Linting**: `pnpm lint` (oxlint, type-aware)
- **Testing**: `pnpm test`
- **Formatting**: `pnpm format`
79 changes: 0 additions & 79 deletions apps/web/src/scripts/fix-ts-errors.sh
View file
Open in desktop

This file was deleted.

177 changes: 0 additions & 177 deletions apps/web/src/scripts/ts-error-docs.md
View file
Open in desktop

This file was deleted.

31 changes: 7 additions & 24 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"dev:training-server": "NODE_ENV=development tsx apps/web/src/lib/services/training/server.ts",
"dev:websocket": "NODE_ENV=development tsx apps/web/src/server.ts",
"dev:academic-sourcing": "ENV=development uv run uvicorn ai.sourcing.academic.api.main:app --host 0.0.0.0 --port 8000 --reload",
"dev:all-services": "scripts/dev/health-check.sh --quiet && concurrently \"pnpm dev\" \"pnpm dev:bias-detection\" \"pnpm dev:ai-service\" \"pnpm dev:analytics\" \"pnpm dev:worker\" \"pnpm dev:training-server\" \"pnpm dev:websocket\" \"pnpm dev:academic-sourcing\" \"pnpm bias:py\"",
"dev:all-services": "concurrently \"pnpm dev\" \"pnpm dev:bias-detection\" \"pnpm dev:ai-service\" \"pnpm dev:analytics\" \"pnpm dev:worker\" \"pnpm dev:training-server\" \"pnpm dev:websocket\" \"pnpm dev:academic-sourcing\" \"pnpm bias:py\"",
"agent:runner": "uv run python -m tools.agent_runner run",
"agent:runner:once": "uv run python -m tools.agent_runner run --once",
"agent:triage": "uv run python -m tools.agent_runner triage",
Expand Down Expand Up @@ -88,21 +88,12 @@
"lint:markdown:ci": "node scripts/ci/lint-changed.mjs --markdown",
"lint:markdown:ci:all": "pnpm exec markdownlint --config .markdownlint.json --ignore node_modules --ignore '**/node_modules/**' \"**/*.md\" \"**/*.mdx\"",
"lint:fix": "oxlint -c .oxlintrc.json --fix-dangerously . && pnpm lint:no-suppressions",
"typecheck": "NODE_OPTIONS='--max-old-space-size=8192' astro check && NODE_OPTIONS='--max-old-space-size=8192' tsc --noEmit",
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Resolved
"typecheck:strict": "NODE_OPTIONS='--max-old-space-size=8192' tsx scripts/validate-typescript.ts",
"type-check": "pnpm run typecheck",
"check": "NODE_OPTIONS='--max-old-space-size=8192' astro check",
"check:all": "pnpm run check && pnpm run typecheck",
"ts:debug": "./debug-typescript.sh normal",
"ts:debug:verbose": "./debug-typescript.sh verbose",
"ts:debug:minimal": "./debug-typescript.sh minimal",
"ts:debug:clean": "./debug-typescript.sh clean",
"ts:debug:repro": "./debug-typescript.sh repro",
"ts:debug:monitor": "./debug-typescript.sh monitor",
"ts:check:debug": "tsc --noEmit --project config/tsconfig.debug.json",
"ts:check:main": "tsc --noEmit --project config/tsconfig.json",
"ts:check:aws": "tsc --noEmit --project config/tsconfig.aws.json",
"ts:compare": "pnpm run ts:check:debug && echo '✅ Debug config works' && pnpm run ts:check:main && echo '✅ Main config works'",
"ts:switch:debug": "cp config/tsconfig.json config/tsconfig.json.backup && cp config/tsconfig.debug.json config/tsconfig.json",
"ts:switch:main": "cp config/tsconfig.json.backup config/tsconfig.json",
"ts:logs": "echo 'TypeScript logs location varies by system. Run: ./debug-typescript.sh normal'",
Comment thread
daggerstuff marked this conversation as resolved.
Resolved
Expand Down Expand Up @@ -206,7 +197,7 @@
"submodules:update": "git submodule update",
"submodules:sync": "git submodule init && git submodule update",
"jules:setup": "bash scripts/devops/jules-setup.sh",
"jules:check": "git status | grep 'on branch staging' || (echo '❌ ERROR: Jules must work on staging branch' && exit 1) && pnpm check:all",
"jules:check": "git status | grep 'on branch staging' || (echo '❌ ERROR: Jules must work on staging branch' && exit 1) && pnpm lint",
"hooks:install": "if [ -f scripts/devops/install-git-hooks.sh ]; then bash scripts/devops/install-git-hooks.sh; else echo \"Skipping git hooks install: scripts/devops/install-git-hooks.sh not found.\"; fi",
"prepare": "husky && pnpm run -s hooks:install",
"safe": "./scripts/utils/no-fail.sh",
Expand All @@ -216,23 +207,16 @@
"safe:test:e2e": "./scripts/utils/no-fail.sh pnpm run test:e2e",
"safe:test:all": "./scripts/utils/no-fail.sh pnpm run test:all",
"safe:lint": "./scripts/utils/no-fail.sh pnpm run lint",
"safe:typecheck": "./scripts/utils/no-fail.sh pnpm run typecheck",
"tags:create": "node scripts/tag-manager.js create",
"tags:list": "node scripts/tag-manager.js list",
"tags:validate": "node scripts/tag-manager.js validate",
"tags:cleanup": "node scripts/tag-manager.js cleanup",
"tags:maintenance": "node scripts/tag-maintenance.js full-maintenance",
"version:release": "node scripts/version-manager.js release",
"version:info": "node scripts/version-manager.js info",
"tags:create": "node scripts/utils/tag-manager.cjs create",
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Resolved
"tags:list": "node scripts/utils/tag-manager.cjs list",
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Resolved
"tags:validate": "node scripts/utils/tag-manager.cjs validate",
"tags:cleanup": "node scripts/utils/tag-manager.cjs cleanup",
"toolbar:on": "astro preferences enable devToolbar",
"toolbar:off": "astro preferences disable devToolbar",
"blog-publisher": "tsx apps/web/src/lib/scripts/blog-publisher.ts",
"blog": "node scripts/blog-web.js",
"blog": "node scripts/content/blog-web.js",
"schedule-posts": "node scripts/content/schedule-posts.js",
"mcp:installer": "pnpm exec cursor-mcp-installer-free /workspaces/pixelated",
"mcp:list": "node scripts/mcp-manager.js list",
"mcp:run": "node scripts/mcp-manager.js run",
"mcp:manage": "node scripts/mcp-manager.js",
"backend:up": "set -a && . ./.env.backend && set +a && docker compose -f infra/docker/docker-compose.backend.yml up -d",
"backend:down": "set -a && . ./.env.backend && set +a && docker compose -f infra/docker/docker-compose.backend.yml down",
"backend:logs": "set -a && . ./.env.backend && set +a && docker compose -f infra/docker/docker-compose.backend.yml logs -f",
Comment thread
sentry[bot] marked this conversation as resolved.
Resolved
Expand Down Expand Up @@ -402,7 +386,6 @@
"@ai-sdk/mcp": "^2.0.29",
"@ai-sdk/provider": "^4.0.8",
"@ai-sdk/sandbox-vercel": "^1.0.87",
"@astrojs/check": "^0.9.10",
"@astrojs/markdoc": "^2.1.1",
"@astrojs/node": "^11.1.4",
"@astrojs/react": "^7.1.1",
Comment thread
sentry[bot] marked this conversation as resolved.
Resolved
Expand Down
Loading
Loading