Repository navigation
chore: delete orphan web UI components and layouts - #6450
Merged
Merged
Conversation
Remove Mintlify docs/mdx/fm clusters, unused homepage and enterprise sections, self-contained backgrounds, orphan mizu marketing blocks, AdvancedFilteringComponent pair, and layouts with zero page imports. Update np-tokens layout comment, CI large-file baseline, and stale BlogLayout e2e expectations.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis deletion-only cleanup removes 64 verified-unreferenced web components and layouts, while updating the token compatibility note, file-size baseline, lockfile, and blog E2E test for the layouts that remain. Lint and build pass; unit-test failures are reported as pre-existing baseline failures. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
px Advisor ReviewRisk: unknown No summary available No findings. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
px Advisor ReviewRisk: unknown No summary available No findings. |
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
Comment on lines
1769
to
1774
| specifier: ~5.7.3 | ||
| version: 5.7.3 | ||
|
|
||
| foresight/cli: | ||
| dependencies: | ||
| '@clack/prompts': | ||
| specifier: ^0.7.0 | ||
| version: 0.7.0 | ||
| commander: | ||
| specifier: ^12.1.0 | ||
| version: 12.1.0 | ||
| ioredis: | ||
| specifier: ^5.4.1 | ||
| version: 5.11.1([email protected]) | ||
| ora: | ||
| specifier: ^8.1.1 | ||
| version: 8.2.0 | ||
| pg: | ||
| specifier: ^8.13.0 | ||
| version: 8.23.1 | ||
| picocolors: | ||
| specifier: ^1.1.0 | ||
| version: 1.1.1 | ||
| devDependencies: | ||
| '@types/node': | ||
| specifier: ^22.9.0 | ||
| version: 22.20.5 | ||
| '@types/pg': | ||
| specifier: ^8.11.10 | ||
| version: 8.23.1 | ||
| tsup: | ||
| specifier: ^8.3.5 | ||
| version: 8.5.1([email protected])([email protected])([email protected])([email protected])([email protected]) | ||
| typescript: | ||
| specifier: ^5.7.2 | ||
| version: 5.9.3 | ||
| vitest: | ||
| specifier: ^4.1.10 | ||
| version: 4.1.12(@opentelemetry/[email protected])(@types/[email protected])(@vitest/[email protected])([email protected](@noble/[email protected]))([email protected](@types/[email protected])([email protected])([email protected])([email protected])([email protected](@types/[email protected])([email protected])([email protected])([email protected])([email protected])([email protected])))([email protected](@types/[email protected])([email protected])([email protected])([email protected])([email protected])([email protected])) | ||
|
|
||
| packages/autoreview: | ||
| dependencies: | ||
| '@ai-sdk/anthropic': |
Contributor
There was a problem hiding this comment.
Bug: Removing foresight/cli from pnpm-lock.yaml while keeping it in pnpm-workspace.yaml causes pnpm install --frozen-lockfile to fail when submodules are checked out.
Severity: MEDIUM
Suggested Fix
Regenerate pnpm-lock.yaml in an environment where the foresight submodule is checked out so that the foresight/cli importer and its dependencies are preserved, or remove 'foresight/cli' from pnpm-workspace.yaml if the package is being deprecated.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: pnpm-lock.yaml#L1769-L1774
Potential issue: The `foresight/cli` importer and its associated dependencies were
removed from `pnpm-lock.yaml`, likely due to regenerating the lockfile in an environment
where the `foresight/` submodule was not checked out. However, `pnpm-workspace.yaml`
still lists `'foresight/cli'` as a workspace package. In CI environments or developer
setups where submodules are checked out, running `pnpm install --frozen-lockfile` will
fail with an `ERR_PNPM_OUTDATED_LOCKFILE` error because a configured workspace package
is missing from the lockfile.
px Advisor ReviewRisk: unknown No summary available No findings. |
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
px Advisor ReviewRisk: unknown No summary available No findings. |
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
px Advisor ReviewRisk: unknown No summary available No findings. |
Lighthouse CI ResultsRoutes audited: Thresholds: Performance ≥90 | Accessibility ≥90 | Best Practices ≥85 Reports
|
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure subtraction: removes Astro/React UI under
apps/web/src/components/andapps/web/src/layouts/that had no live importers after re-verifying withrg(static imports,@/aliases,dynamic-components.tsx,import.meta.globinastro.config.mjs, and page/layout graphs). No refactors or replacements.64 component/layout files deleted (~7,391 net lines). Supporting edits only:
np-tokens.csscomment,large-file-baseline.json, and a stale Playwright blog-layout test.Deleted clusters
Mintlify-style docs (
components/docs/**) — 22 filesAccordion,AccordionGroup,Aside,Card,CardGrid,CardGroup,Cards,Check,CodeGroup,Expandable,Frame,Info,Latex,Note,ResponseField,SnippetIntro,Steps,Tab,TabItem,Tabs,Tip,WarningMDX duplicates (
components/mdx/**) — 2 filesAccordion.astro,AccordionGroup.astroFM marketing primitives (
components/fm/**) — 9 filesFmAnnotation,FmChip,FmCodeDeco,FmCtaBlock,FmEyebrow,FmHairlineCell,FmHairlineGrid,FmMarquee,FmSectionBackground kit (
components/backgrounds/**) — 5 filesSelf-referential only (
Background→Plum/Rose;Dot,Particleunused).Enterprise chrome — 3 files
EnterpriseHeader.astro,EnterpriseFooter.astro,EnterpriseHero.astroLegacy homepage sections (
components/homepage/**) — 11 filesAtmosphere,DataPoint,HeroAtmosphere,HeroContent,HeroStage,HeroStatsBand,InfoStrip,IntroSection,ScenariosSection,SectionAtmosphere,WorkflowSection(landing usescomponents/landing/SimulationWorkstation.astroviapages/index.astro).Mizu marketing blocks — 7 files
CTA,CoreFeatures,FAQ,FeatureIcon,Features,Logos,TestimonialsOrphan layouts — 3 files
BlogLayout.astro,StandardLayout.astro,AdminDashboardLayout.astro(blog and admin pages useBaseLayout,DashboardLayout, orAdminLayoutinstead).Analytics dead weight — 2 files
AdvancedFilteringComponent.astro,AdvancedFilteringComponent.tsx(~1,820 LOC combined; no importers outside the pair).Kept (still imported)
components/mizu/Navbar.astroDocumentationLayout.astrocomponents/mizu/Footer.astroDocumentationLayout.astro,DashboardLayout.astroOther touch-ups
apps/web/src/styles/np-tokens.css: legacy layout comment now lists layouts that still have page imports (BrutalistLayout,ChatLayout,DashboardLayout,DocumentationLayout,TabbedLayout); dropped staleBlogLayout,TailusLayout, and never-imported names.scripts/ci/large-file-baseline.json: removed entries for deleted AdvancedFiltering files.tests/e2e/infrastructure/layout-integration.spec.ts: blog test updated for/blogonBaseLayout(old test targeted removedBlogLayoutselectors).Historical references in
content-store/**and committedpublic/test-results/**artifacts were left unchanged (not runtime imports).Verification
pnpm lintpnpm buildpnpm test:unitstaging:graphql-yoga/@graphql-tools/utilsexport (graphql.test.ts) and month-boundary flake (versioning.test.ts); no new failures vs baselineSummary by Sourcery
Delete orphaned web UI components and layouts while updating related compatibility metadata and tests to preserve coverage for active pages.
Enhancements:
Build:
Tests: