Skip to content

feat(watchlist): key holdings by security, show closed funds - #89

Merged
daggerok merged 1 commit into
mainfrom
feat/ui-securities
Oct 26, 2026
Merged

daggerok merged 1 commit into
mainfrom
feat/ui-securities

Conversation

@daggerok

Copy link
Copy Markdown
Owner

What changed

Same port as Neos daggerok/Neos#71 (shared blocks watchlist-key.tsx, closed-badge.tsx, closed.css, ported with securities.ts of workspace ui-std):

  • Watchlist rows merge by security: CUSIP, ISIN, FIGI or SEDOL (recognized by format and check digit, whatever column holds them; a US or Canadian ISIN also gives its CUSIP), else by ticker and name. A ticker alone never merges anything
  • Ticker and name join one security published with different identifier kinds only when none of the groups with that ticker and name disagree on a CUSIP, ISIN or SEDOL; debt rows (bond asset class, coupon or maturity) never meet the issuer stock
  • The Ticker column still shows the ticker; Copy Tickers copies each real ticker once, never a CUSIP or name stand-in
  • Closed funds (status: closed, closedDate, closedSource in index.json) keep their row with a Closed <date> badge that links the closing notice; the Fund Name filter (closed, !closed) and the search find them
  • The page loader reads holdings published as header+array rows too, not only objects

Why

ETF-C3: different securities with one ticker became one Watchlist row (ACA of Arcosa and Credit Agricole before the ticker fix, T on Treasuries and AT&T). Q21: closed funds were not visible as closed

How it was checked

  • bun test: 45 pass, 0 fail
  • bun run build, bun build --target=bun src/main.tsx --outfile=/dev/null, git diff --check
  • tc/check.sh: 48 lines, same as on main, nothing new
  • Browser (headless, silent) on dist: brand-uitest-spdr.ts 44 passed, columns-uitest.ts 19, categories-uitest.ts 19, clear-uitest.ts 19, security-uitest.ts 20, all 0 failed; console errors: none

Ports the shared watchlist-key, closed-badge and closed.css blocks (ui-std securities.ts) as in Neos #71.
@daggerok
daggerok merged commit 78adc35 into main Oct 26, 2026
1 check passed
@daggerok
daggerok deleted the feat/ui-securities branch October 26, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant