Repository navigation
bench.sh: detect failed runs and fail accordingly - #246
Merged
Merged
Conversation
derSteFfi
force-pushed
the
detect_errors_in_runs
branch
from
September 30, 2025 12:08
4786aa1 to
acc164a
Compare
This was referenced Oct 1, 2025
derSteFfi
force-pushed
the
detect_errors_in_runs
branch
from
October 26, 2026 09:33
5cf976b to
5a9e60a
Compare
Contributor
Author
|
I've rebased the MR onto |
Collaborator
|
The CI is failing hard |
Contributor
Author
|
I assure its just errors that are there but now are visible. For example, current master has this error in ubuntu/gs/mi: log. CI still reports a success even though no gs instance on ubuntu is currently run with a preloaded allocator. This MR tries to catch all those errors to have a todo list to fix. The actual gs problem is fixed in #279 nonetheless. To find all remaining issues, this MR correctly reports them so the CI is not false-green. |
jvoisin
approved these changes
Nov 1, 2026
because redis has to be detected in a more complicated way, rework the output and remove superfluous sleeps while at it. the server startup wait is bounded (with a hard timeout on redis-cli), and the server is always torn down by pid: when it dies or hangs under the preloaded allocator the run is marked failed instead of hanging the whole benchmark.
derSteFfi
force-pushed
the
detect_errors_in_runs
branch
from
November 2, 2026 09:47
5a9e60a to
51d42fb
Compare
Contributor
Author
|
rebased again. |
jvoisin
reviewed
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because redis has to be detected in a more complicated way, rework the output and remove superflouos sleeps while at it.
Fixes #245