feat: allow strOut argument to fsst_compress to be NULL - #47
Open
mhx wants to merge 1 commit into
Open
Conversation
The contents of `strOut` are strictly redundant as long as the lengths in `lenOut` are known. For long lists of strings, having to allocate a large buffer that is essentially going to be unused is something that should not be forced upon the user. The overhead for the additional check should be negligible even in the case where the pointer array is actually used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contents of
strOutare strictly redundant as long as the lengths inlenOutare known. For long lists of strings, having to allocate a large buffer that is essentially going to be unused is something that should not be forced upon the user. The overhead for the additional check should be negligible even in the case where the pointer array is actually used.