Repository navigation
fix: hide opponent hand when rematching a reopened finished game - #1433
Open
SamuelHetes wants to merge 3 commits into
Open
SamuelHetes wants to merge 3 commits into
SamuelHetes wants to merge 3 commits into
Conversation
itsalaidbacklife
requested changes
Oct 11, 2026
itsalaidbacklife
left a comment
Contributor
There was a problem hiding this comment.
Great work. Thanks for the fix! One nitpick on the e2e test and then this is ready
itsalaidbacklife
approved these changes
Oct 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number
Reopening a finished game joined the original player to the spectator socket room, causing their next rematch to reveal the opponent's hand. Keep players in their p0/p1 rooms in both game-loading and spectate actions, while preserving full visibility when viewing finished games.
Please check the following
Please describe additional details for testing this change
Added Cypress regressions for both navigation paths and 20 controller unit tests covering player/spectator rooms, visibility, and live-game self-spectating restrictions. The URL regression failed before the fix and passed afterward.
Validation on Node 22.21.1: lint and build passed; all 106 unit tests passed. All 34 standard E2E specs were run: final results were 387 passed and 5 existing pending tests. One game-creation setup timeout in
live-spectating.spec.jspassed on an isolated rerun of the entire spec (12/12), without code changes. GitHub CI remains to be run.