Repository navigation
Fix no-template-shadow warning in StatsLeaderboardCell - #1431
Merged
itsalaidbacklife merged 2 commits intoOct 8, 2026
Merged
Conversation
The slot var shadowed the component props in StatsLeaderboardCell.
itsalaidbacklife
added
dev experience
itsalaidbacklife
approved these changes
Oct 8, 2026
itsalaidbacklife
left a comment
itsalaidbacklife
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution! Will merge pending CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1430
Issue number
Please check the following
Please describe additional details for testing this change
Renamed the activator slot binding to menuProps so it stops shadowing the component props. I ran eslint on the file and the full lint, both are clean now. Unit tests pass (3/3 client). The e2e stats spec needs a live server so I couldnt run that here.