Guard short Michelin advertisements - #1590
Merged
Ernst79 merged 1 commit intoSep 8, 2026
Merged
Conversation
Ernst79
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent short Michelin TMS advertisements from raising
IndexErrorduring parsing.Problem
parse_michelin_tms()accesseddata[5]before validating that the manufacturer data contained at least six bytes.The shared dispatcher does not enforce a sufficient minimum length for Michelin advertisements, so truncated packets could reach the parser and raise an exception.
Fix
Reject Michelin TMS payloads shorter than six bytes before accessing the frame-type byte.
Valid Michelin advertisements and the existing frame specific validation remain unchanged.
A regression test covers truncated manufacturer data.