Handle malformed Sonoff advertisements - #1589
Merged
Ernst79 merged 1 commit intoSep 8, 2026
Merged
Conversation
Ernst79
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent malformed or unsupported Sonoff BLE advertisements from causing parser exceptions.
Problem
The Sonoff parser had two failure cases:
IndexError.device_typeundefined whenreport_unknownwas disabled, resulting inUnboundLocalError.Fix
Require the minimum payload length actually needed by the parser before processing the advertisement.
Also ensure unknown Sonoff device types always return cleanly after the optional diagnostic logging path.
Known Sonoff S-MATE and R5 parsing remains unchanged.
Regression tests cover truncated advertisements and unknown device types.