Handle invalid Xiaomi KS1 button events - #1585
Merged
Ernst79 merged 4 commits intoSep 8, 2026
Merged
Conversation
Ernst79
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent invalid Xiaomi KS1/KS1BP button events from causing parser exceptions.
Problem
obj560c(),obj560d(), andobj560e()returnedNonefor unrecognized click values and unsupported device types.The Xiaomi parser passes object-parser results directly to
dict.update(), so these cases could result in:TypeError: 'NoneType' object is not iterableBoth the device identifier and click value originate from the BLE advertisement and may contain unexpected values.
Fix
Return an empty result for unrecognized click values and unsupported device types instead of
None.Recognized KS1/KS1BP single click, double click, and long press events remain unchanged.
Regression tests cover invalid inputs and representative valid button events.