Guard truncated Xiaomi toothbrush payloads - #1575
Merged
Ernst79 merged 1 commit intoSep 8, 2026
Merged
Conversation
Ernst79
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent malformed Xiaomi toothbrush MiBeacon objects from raising an exception during parsing.
Problem
obj3003()parses brushing start/end events containing a one-byte event marker followed by a four-byte timestamp.The object payload length comes from the BLE advertisement, but the parser attempted to unpack the timestamp without first verifying that the payload contained enough bytes.
A truncated object with a start or end marker could therefore raise
struct.errorand propagate out of the parser.The function also contained an unconditional leftover
print()statement that wrote brushing payloads to stdout.Fix
Reject
obj3003payloads shorter than the five bytes required for the event marker and timestamp.Valid five byte and six byte brushing payloads remain unchanged, including the optional brushing score.
The stray stdout debug print was also removed.
A regression test covers truncated
obj3003payloads.