Handle unknown Grundfos pump modes - #1573
Merged
Ernst79 merged 1 commit intoSep 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle unknown Grundfos MI401 pump mode values without crashing the BLE parser.
Problem
The Grundfos parser used a direct lookup in
PUMP_MODE_DICT.If a device reports a pump mode that is not currently known by the integration, the lookup raises
KeyError. Since the value comes directly from the BLE advertisement, this can also happen with malformed packets or future firmware introducing a new mode.Fix
Use a safe dictionary lookup and report unknown values as:
Unknown (<value>)Known pump modes remain unchanged.
A regression test covers an advertisement containing pump mode
255.