Update MessageBuilder when runner generate messages - #1882
Conversation
4007e67 to
402b6ea
Compare
|
Requires cucumber-core 18.1+ |
|
@brasmusson I think this has lots of code that has already been merged into |
* Changes when the runner generate test_case_started/finished messages at the source.
* Changes when the runner generate test_step_started/finished messages at the source.
* Pass also the id_generator to the runner.
402b6ea to
6374484
Compare
|
|
||
| @current_test_case_started_id = event.envelope.test_case_started.id | ||
| @current_test_run_hook_started_id = nil | ||
| @repository.update(event.envelope) |
There was a problem hiding this comment.
Writing this as a new comment. Now I understand the change on line 55.
I still think we need to fully update the repository after each envelope. So imo this should be moved above line 55.
Given every line now in this method is just assigning an iVar, we could even move the update call to the first line, to make it cleaner and leaner (As in here we always have the envelope already and don't need to generate it - which was the reason for it being at the bottom of all other on_.... handlers)
|
Note to self and @brasmusson I've merged a piece of work which naturally breaks a couple of tests. This PR should also fix the tests. It looks like it's just one feature test - The failure looks "good" (Duplication of message output).
|
2 participants
Description
Depend on cucumber/cucumber-ruby-core#331
Type of change
Please delete options that are not relevant.
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses