Repository navigation
ui: dark is readable, and a version nobody compared is not zero - #42
Merged
Merged
Conversation
The dark window was drawing every card on the colour the card was meant to stand on: 0.3.14 had taken the phone's M3 palette, where background and surface are both #141318. One flat black field, separated only by hairlines — which is what "深色模式 啥都看不清" describes. The desktop's own dark tokens are back, value for value from html[data-theme="dark"]: canvas #0F1116, panel #181B21, raised #1E222A, sunken #242932, selection #1D2C3E. Two text weights stay above the prototype, because the prototype's are sized for a browser: --dim #98A1B0 is 5.4:1 on a panel and --dim-2 #6D7686 is 2.8:1, and both carry whole sentences at 11–12sp here. They are #C2CAD8 and #97A0AE now, which is 9.6:1 and 5.7:1. The exception is written down in the design repo, not in a comment. Also: with no peer, 本机版本 / 远端版本 read "100 / 0", and 0 looks like a build from before the protocol existed. It reads an em dash now, like the other empty values. The preview fixture empties its scratch area per screenshot rather than once per JVM: a state left behind by the previous test was being photographed in the next one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
html[data-theme="dark"]色板（画布#0F1116/ 卡片#181B21/ 浮起#1E222A/ 下沉#242932/ 选中#1D2C3E）。0.3.14 借了手机 M3 色板，background与surface同为#141318，每张卡片落在它本该浮起的那个颜色上 —— 整窗一块黑板，只剩细线分区。这是「深色模式啥都看不清」的直接原因。决策记录/0002：--dim#98A1B0→#C2CAD8（对卡片 5.4:1 → 9.6:1）、--dim-2#6D7686→#97A0AE（2.8:1 → 5.7:1）。原型这两档按浏览器字号定，这里 11–12sp 要承担整句说明。100 / 0，改占位符 —— 0 读起来像协议之前的构建。桌面 13 张基线按新色重录；手机端未改色板，基线未动。
./gradlew check绿。