Repository navigation
Feature/rework views - #57
Merged
Merged
Conversation
Feature/refactor rework views
The Tailwind redesign had been landing as a parallel track next to the
original Bootstrap UI: a Redesign:: Ruby namespace, redesign-prefixed
directories in app/javascript, app/assets/stylesheets and app/views, a
second Stimulus application, a second layout, and a RedesignLayout
concern controllers opted into.
That conversion was effectively done — 21 of 24 controllers already
rendered under the redesign layout. The only things still on the
legacy Bootstrap path were StudentsProfileController (unreferenced by
any route helper or link anywhere in the app), students#new/create
("Dodaj studenta"), and its entry point/partial — all dead weight,
deleted outright rather than converted.
With those gone, nothing rendered through the Bootstrap/legacy
Stimulus stack any more, so the rest of that stack (the legacy layout,
its Sass tree, its 12 Stimulus controllers, its Shared::* chrome
components) was deleted too, along with two more pieces of dead code
this surfaced: MessagesComponent and two Notification broadcasts that
targeted the removed Bootstrap markup.
With only one implementation left, the redesign's naming is promoted
to be the app's only naming: Redesign::Foo -> Foo across
app/services, app/values and the shared components; the
RedesignLayout concern is folded into a single ApplicationController
default; RedesignHelper is merged into ApplicationHelper; and every
redesign.*/redesign/ file and directory (JS, CSS, images, views) is
renamed to the plain names Bootstrap's removal freed up
(redesign.ts -> application.ts, layouts/redesign.html.haml ->
layouts/application.html.haml, and so on).
Tests and docs follow: the *_redesign_smoke_test.rb files drop the
suffix, tests asserting old two-layout behavior are updated, and
CLAUDE.md's "Redesign in progress" section — which pointed at the
already-deleted design/ mockup directory — is replaced with a short
note on where the frontend pieces live now.
Feature/refactor2 rework views
…ub8/Gamification-Hub into feature/refactor3-rework-views
Feature/refactor3 rework views
Feature/refactor4 rework views
cub8
marked this pull request as ready for review
September 30, 2026 20:45
ewez43
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poprawa widoków