Skip to content

chore: retire the dead ASHIGARU_APP_ID secret passthrough - #30

Merged
fatherlinux merged 1 commit into
mainfrom
chore/retire-ashigaru-app-id
Nov 10, 2026
Merged

fatherlinux merged 1 commit into
mainfrom
chore/retire-ashigaru-app-id

Conversation

@fatherlinux

Copy link
Copy Markdown
Member

Removes the ASHIGARU_APP_ID secret passthrough from this repo's Ashigaru caller. The secret is dead plumbing: the reusable workflows mint every token from the ASHIGARU_CLIENT_ID variable and the ASHIGARU_APP_KEY secret, and nothing reads the App ID. crunchtools/ashigaru v2.12.0 already dropped its required: true declaration, so passing it here is only a warning and this removal is safe.

Fleet sweep for RT#1555. Opened by fleet-retire-app-id.py.

Generated with Claude Code

@fatherlinux
fatherlinux enabled auto-merge (squash) November 10, 2026 07:49

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatehouse found no issues.

Full review.

1 finding(s) dropped: their evidence is not in the diff.

1 of 8 agents served by google/gemini-3.1-flash-lite (primary unavailable).

@fatherlinux
fatherlinux merged commit 6684de5 into main Nov 10, 2026
6 checks passed
@fatherlinux
fatherlinux deleted the chore/retire-ashigaru-app-id branch November 10, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant