Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
uses: actions/checkout@v7

- name: Download image artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM (Security Scan): actions/download-artifact is an external action referenced by the mutable major tag @v8. If that tag is moved, the workflow could execute a different action revision with the job's permissions.

Suggestion: Pin the action to a verified full commit SHA, optionally retaining v8 in a comment for readability.

Evidence:

uses: actions/download-artifact@v8

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bug: the fleet references actions/* at the major tag deliberately. Constitution XV rule 2 requires a Dependabot update path for the github-actions ecosystem and rule 4 auto-merges green minor/patch bumps — both of which need a moving semver tag, not a SHA. Every workflow in the org reads actions/checkout@v7 the same way. This PR does not introduce the pattern; it moves an existing @v4 reference to @v8 and leaves the pinning style alone. Switching the fleet to SHA pins is a constitution change, not a change to this Dependabot PR.

with:
name: container-image
path: /tmp
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
contents: read
steps:
- name: Download image artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM (Security Scan): actions/download-artifact is an external action referenced by the mutable major tag @v8. If that tag is moved, the workflow could execute a different action revision with the job's permissions.

Suggestion: Pin the action to a verified full commit SHA, optionally retaining v8 in a comment for readability.

Evidence:

uses: actions/download-artifact@v8

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bug: the fleet references actions/* at the major tag deliberately. Constitution XV rule 2 requires a Dependabot update path for the github-actions ecosystem and rule 4 auto-merges green minor/patch bumps — both of which need a moving semver tag, not a SHA. Every workflow in the org reads actions/checkout@v7 the same way. This PR does not introduce the pattern; it moves an existing @v4 reference to @v8 and leaves the pinning style alone. Switching the fleet to SHA pins is a constitution change, not a change to this Dependabot PR.

with:
name: container-image
path: /tmp
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
# so Quay and GHCR carry the identical image rather than two builds that
# merely started from the same commit.
- name: Download image artifact
uses: actions/download-artifact@v4
uses: actions/download-artifact@v8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM (Security Scan): actions/download-artifact is an external action referenced by the mutable major tag @v8. If that tag is moved, the workflow could execute a different action revision with the job's permissions.

Suggestion: Pin the action to a verified full commit SHA, optionally retaining v8 in a comment for readability.

Evidence:

uses: actions/download-artifact@v8

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bug: the fleet references actions/* at the major tag deliberately. Constitution XV rule 2 requires a Dependabot update path for the github-actions ecosystem and rule 4 auto-merges green minor/patch bumps — both of which need a moving semver tag, not a SHA. Every workflow in the org reads actions/checkout@v7 the same way. This PR does not introduce the pattern; it moves an existing @v4 reference to @v8 and leaves the pinning style alone. Switching the fleet to SHA pins is a constitution change, not a change to this Dependabot PR.

with:
name: container-image
path: /tmp
Expand Down
Loading