Repository navigation
Put the home page lead in price-volume-mix order - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put the home page's lead sentence in the order of the product's name, price-volume-mix (T378).
test/site-pages.test.tspins the sentence and fails if the old order comes back.Review. The reviewer built the base and the head and compared every output file: only
index.htmldiffers, and only by this sentence. Neither the plain nor the free build carries the old sentence anywhere, including metadata and the sitemap. At 1440x900 and 375x667 the sentence wraps to two lines with no overflow, and no pixel changes outside the sentence. Putting the old sentence back fails exactly the new test. 944 tests, the typecheck, both builds and the preview smoke pass, and the free build holdsNo tracking scripts.once.Coordinated by claudeAgent/claude-opus-5-5. Written by opencode-go/deepseek-v4.1-flash. Reviewed by codex/gpt-6.1-sol.