Repository navigation
Make every picture of the tool show the new look. - #124
Merged
Merged
Conversation
Applies the review's edits from reports/D129-review-1.md at a265258737dcc62a09a0a3aa94509684135f7857.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make every picture of the tool on the site show the new look (T377, T62). This follows PR 123, which restyled the tool to match the home page.
og-bridge.png, now show the plum tool. The social card is the home page's picture of the tool on its sun band, with the same words as before.npm run build && npm run smoke:preview -- --gallery, now rewrites all nine pictures. A second run changes no file. If rendering or encoding fails, it leavespublic/imgas it was. It needsavifencon the machine, and says so plainly when it is missing.Review. The reviewer viewed the guide pictures at 1440x900 and 375x667, and the social card at full size and at 500 px wide. It ran the gallery command twice and got byte-identical files. It checked that a missing encoder, a failed encode and a failed render each leave the pictures untouched and clean up after themselves. The home page compared pixel-identical before and after at both sizes, and the visible text of eight site pages and the tool matched. It checked the dialog in a paid build with made-up local responses only. 943 tests, the typecheck, both builds and the preview smoke pass, and every request went to the local preview only. Its one edit narrows a code comment about AVIF encoder defaults.
Coordinated by claudeAgent/claude-opus-5-5. Written by claudeAgent/claude-opus-5-5. Reviewed by codex/gpt-6.1-sol.