Skip to content

Fix the tool findings from the second QA run. - #122

Merged
creedants merged 13 commits into
mainfrom
landing/e61
Oct 28, 2026
Merged

creedants merged 13 commits into
mainfrom
landing/e61

Conversation

@creedants

Copy link
Copy Markdown
Owner

Fix the tool findings from the second first-time-user QA run on 2026-10-28 (T369). The bridge's numbers are unchanged.

  • Suggest attributes now looks like a button, not a text box.
  • The line under a disabled Calculate bridge names only what is missing, for example Choose at least one attribute. or Choose units and sales.
  • While the calculation engine loads, a moving bar shows. A file picked during the wait is acknowledged: Got <file name>. It opens as soon as the calculation engine has loaded.
  • Loading your own file or pasting data removes ?sample from the address, so a reload no longer brings the sample back.
  • The tool shows Privacy, Terms and Contact links, and It is not uploaded. links to the privacy page.
  • On phones the preview hint reads First rows of the file. Set up the bridge above, then choose Calculate bridge., and the example table shows the period, units and sales columns without sideways scrolling.
  • Chart labels no longer overlap or hide a sign with long names or huge values. On touch, the first tap shows a bar's value with a Show movers link, and a swipe leaves no highlight.
  • Explanations. A note explains a Discontinued or New configurations sign a reader would not expect: Discontinued configurations is an increase here. The line is not the sales that were lost. (and the matching New sentence), then It is the difference from the nearest comparable group, which can go either way. Other new sentences: + combine joins another column into the same attribute, so the two count as one. and One attribute gives a classic bridge: volume, one mix step and price. Setup check adds An attribute that describes the customer, such as region or channel, can also move price a lot. and It belongs last in the order, or it can be left out.
  • The period column is no longer offered as Units or Sales. A new file resets Prior and Current when the old choices do not fit it.
  • Load setup errors show beside the button. A Movers search with no match says No rows match.
  • Clear data asks Clear the loaded data and the bridge? first.
  • A double or triple click on any save button saves one file. All rows now saves as movers-all-rows.csv.
  • When amounts are too large to add up exactly, the Bridge tab now shows the same warning as the Data check.

Review. The reviewer checked a production preview at 1440x900 and on a 375x667 touch phone, with real file uploads and slow 3G with a 4x slower CPU. It confirmed all 13 points. The bridge table was byte-identical before and after, both for the sample and for an uploaded file. Each save button saved one file on a triple click. Its one edit corrects a code comment to say that Excel export keeps its own save guard. 933 tests, the typecheck, both builds and the preview smoke pass. No new request goes to another host.

Coordinated by claudeAgent/claude-opus-5-5. Written by claudeAgent/claude-opus-5-5. Reviewed by codex/gpt-6.1-sol.

@creedants
creedants merged commit ba2c2d4 into main Oct 28, 2026
4 checks passed
@creedants
creedants deleted the landing/e61 branch October 28, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant