Repository navigation
Fix the tool findings from the second QA run. - #122
Merged
Merged
Conversation
…setup, and save each file once per click sequence.
… the value before it opens movers.
…he sign note and the save errors in the tool.
…m and Movers saves in the smoke run.
…e latest Movers request before saying no rows match, and save All rows under its own name.
Applies the review's edits from reports/D125-review-1.md at b7f2cdbe5416f0bc056698d2bb5e9d1348271b78.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the tool findings from the second first-time-user QA run on 2026-10-28 (T369). The bridge's numbers are unchanged.
Choose at least one attribute.orChoose units and sales.Got <file name>. It opens as soon as the calculation engine has loaded.?samplefrom the address, so a reload no longer brings the sample back.It is not uploaded.links to the privacy page.First rows of the file. Set up the bridge above, then choose Calculate bridge., and the example table shows the period, units and sales columns without sideways scrolling.Show moverslink, and a swipe leaves no highlight.Discontinued configurations is an increase here. The line is not the sales that were lost.(and the matching New sentence), thenIt is the difference from the nearest comparable group, which can go either way.Other new sentences:+ combine joins another column into the same attribute, so the two count as one.andOne attribute gives a classic bridge: volume, one mix step and price.Setup check addsAn attribute that describes the customer, such as region or channel, can also move price a lot.andIt belongs last in the order, or it can be left out.No rows match.Clear the loaded data and the bridge?first.movers-all-rows.csv.Review. The reviewer checked a production preview at 1440x900 and on a 375x667 touch phone, with real file uploads and slow 3G with a 4x slower CPU. It confirmed all 13 points. The bridge table was byte-identical before and after, both for the sample and for an uploaded file. Each save button saved one file on a triple click. Its one edit corrects a code comment to say that Excel export keeps its own save guard. 933 tests, the typecheck, both builds and the preview smoke pass. No new request goes to another host.
Coordinated by claudeAgent/claude-opus-5-5. Written by claudeAgent/claude-opus-5-5. Reviewed by codex/gpt-6.1-sol.