Prevent dead source links for local-only commits - #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The exporter verified only that sourceCommit existed in the local object database. The bbolt graph was built at local synthetic commit 0e3e6bf, which is not reachable from origin/main, so Compass emitted a GitHub URL for an object GitHub never received.
Reproduction
Replayed export against /Volumes/Workspace/Github/bbolt/compass-out/graph.json. Before the fix, the HTML embedded revision 0e3e6bf and GitHub returned 404. After the fix, the export omits that dead source-navigation record.
Verification
All Cargo checks used CARGO_TARGET_DIR=/Volumes/Workspace/crabbuild-target/compass-main.