-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added configuration file for Microsoft.GSL library #8738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Patschkowski
wants to merge
2
commits into
cppcheck-opensource:main
Choose a base branch
from
Patschkowski:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <?xml version="1.0"?> | ||
| <def> | ||
| <define name="Expects(x)" value=""/> | ||
| <define name="Ensures(x)" value=""/> | ||
| <define name="GSL_SUPPRESS(x)" value=""/> | ||
| <podtype name="gsl::index" sign="s"/> | ||
| <podtype name="gsl::byte" sign="u" size="1"/><!-- Deprecated in GSL --> | ||
| <container id="gslSpan" startPattern="gsl :: span" inherits="stdSpan"> | ||
| </container> | ||
| <smart-pointer class-name="gsl::owner"/> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please group the smart pointers together and add
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have added the |
||
| <smart-pointer class-name="gsl::not_null"/> | ||
| <smart-pointer class-name="gsl::unique_ptr"><!-- Deprecated in GSL --> | ||
| <unique/> | ||
| </smart-pointer> | ||
| <smart-pointer class-name="gsl::shared_ptr"/><!-- Deprecated in GSL --> | ||
| <smart-pointer class-name="gsl::strict_not_null"/><!-- non-existing in C++ Core Guidelines --> | ||
| </def> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Test library configuration for microsoft_gsl.cfg | ||
| // | ||
| // Usage: | ||
| // $ cppcheck --check-library --library=microsoft_gsl --enable=style,information --inconclusive --error-exitcode=1 --inline-suppr test/cfg/microsoft_gsl.cpp | ||
| // => | ||
| // No warnings about bad library configuration, unmatched suppressions, etc. exitcode=0 | ||
| // | ||
|
|
||
| // C++ Standard Library | ||
| #include <vector> | ||
|
|
||
| // Guideline Support Library | ||
| #include <gsl/gsl> | ||
|
|
||
| struct owner_type | ||
| { | ||
| owner_type() = default; | ||
| owner_type(const owner_type &) = delete; | ||
| owner_type(owner_type &&) = default; | ||
|
|
||
| ~owner_type() { delete ptr_; } | ||
|
|
||
| auto operator=(const owner_type &) -> owner_type & = delete; | ||
| auto operator=(owner_type &&) -> owner_type & = default; | ||
|
|
||
| private: | ||
| gsl::owner<int *> ptr_{new int(42)}; | ||
| }; | ||
|
|
||
| auto pre_and_post_condition_test(int i) -> int | ||
| { | ||
| Expects(i > 0); | ||
|
|
||
| const auto result{i * 2}; | ||
|
|
||
| Ensures(result > 0); | ||
| return result; | ||
| } | ||
|
|
||
| auto suppress_macro_test(std::span<int> s) -> int | ||
| { | ||
| GSL_SUPPRESS("bounds.1") | ||
| return s[0]; | ||
| } | ||
|
|
||
| auto iterate_over_container_test(std::vector<int> v) -> int | ||
| { | ||
| int sum{0}; | ||
|
|
||
| for (gsl::index i{0}; i < v.size(); ++i) | ||
| { | ||
| sum += v[i]; | ||
| } | ||
| return sum; | ||
| } | ||
|
|
||
| void not_null_test(gsl::not_null<int *> p) | ||
| { | ||
| Expects(p != nullptr); | ||
| *p = 42; | ||
| } | ||
|
|
||
| void strict_not_null_test(gsl::strict_not_null<int *> p) | ||
| { | ||
| Expects(p != nullptr); | ||
| *p = 42; | ||
| } | ||
|
|
||
| auto byte_test(gsl::byte b) -> gsl::byte | ||
| { | ||
| return b | 0x81; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.