fix: pin highlight.js script and theme with SRI#145
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughHighlight.js CDN assets now include SRI metadata and anonymous cross-origin loading. Chat rendering only invokes syntax highlighting when Highlight.js is available. ChangesHighlight.js integration safeguards
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bradjin8
approved these changes
Jul 20, 2026
bradjin8
approved these changes
Jul 20, 2026
wpak-ai
requested changes
Jul 21, 2026
wpak-ai
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140
highlight.js was the only cdn tag in base.html without sri. this pins the 11.9.0 script and vs2015 theme with the official cdnjs hashes and crossorigin="anonymous", same as marked and dompurify. no version bump.
checked a fenced code block still highlights and devtools shows no sri errors. pytest tests/test_xss_sanitization.py passes.
Summary by CodeRabbit