Skip to content

chore: declare the Codecov secret, fix the CodeQL input and add a Dependabot cooldown - #126

Merged
shenxianpeng merged 2 commits into
mainfrom
claude/project-thread-b86y81
Nov 1, 2026
Merged

shenxianpeng merged 2 commits into
mainfrom
claude/project-thread-b86y81

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Small fixes from running zizmor and actionlint over the org:

  • py-coverage.yml now declares the CODECOV_TOKEN secret (required, since Codecov needs a token for uploads). clang-tools-pip calls it with secrets: inherit, which zizmor flags because the called workflow then gets every secret of the repo. With the secret declared, callers can pass only CODECOV_TOKEN. Callers that keep secrets: inherit still get the token. After this merges, clang-tools-pip can switch to the explicit secret (follow-up to clang-tools-pip#243).
  • codeql.yml: language had default: "python" but required: true, so the default could never apply (actionlint). It is now optional. All three callers (cpp-linter, clang-tools-pip, cpp-linter-hooks) are Python.
  • dependabot.yml: 7-day cooldown, as in cpp-linter.

zizmor now reports no findings here.

…endabot cooldown

- py-coverage.yml declares CODECOV_TOKEN, so callers can pass just that
  secret instead of secrets: inherit (zizmor secrets-inherit).
- codeql.yml: language had a default but was required, so the default
  never applied (actionlint).
- Dependabot: 7-day cooldown (zizmor dependabot-cooldown).
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a3e0bfa-e8fd-41eb-affe-ab676bc022e1
Commits

Reviewing files that changed from the base of the PR and between 1c9dfcf and dc795bf.

Files selected for processing: 1
  • .github/workflows/py-coverage.yml

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dccafd02-4eb2-4ac1-a2da-5d9917dfa3db
Commits

Reviewing files that changed from the base of the PR and between 257c8ff and 1c9dfcf.

Files selected for processing: 3
  • .github/dependabot.yml
  • .github/workflows/codeql.yml
  • .github/workflows/py-coverage.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The changes update GitHub automation configuration: they add a default cooldown for GitHub Actions dependency updates, make the CodeQL language input optional, and add an optional Codecov token secret to the Python coverage workflow.

Changes

Dependency update timing

Layer / File(s) Summary
GitHub Actions cooldown
.github/dependabot.yml
GitHub Actions dependency updates now have a default 7-day cooldown.

CodeQL workflow input

Layer / File(s) Summary
Optional language input
.github/workflows/codeql.yml
The language input is no longer required. Its type and "python" default remain unchanged.

Coverage workflow secret

Layer / File(s) Summary
Optional Codecov token
.github/workflows/py-coverage.yml
The reusable workflow accepts an optional CODECOV_TOKEN secret and describes it as the token for uploading reports to Codecov.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · previous review 1c9df

The workflow and Dependabot configuration changes are valid and narrowly scoped, with no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies all three main changes: declaring the Codecov secret, fixing the CodeQL input, and adding a Dependabot cooldown.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Comment thread .github/workflows/py-coverage.yml Outdated
secrets:
CODECOV_TOKEN:
description: Token for uploading the report to Codecov
required: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought CodeCov requires a token to upload coverage reports now. I think needs to be required: true.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's required: true now (dc795bf). The only caller, clang-tools-pip, uses secrets: inherit, so it still gets the token. Once this merges, pip will pass CODECOV_TOKEN explicitly instead of inheriting everything.


Generated by Claude Code

@shenxianpeng
shenxianpeng merged commit 95c4e1d into main Nov 1, 2026
9 checks passed
@shenxianpeng
shenxianpeng deleted the claude/project-thread-b86y81 branch November 1, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants