Repository navigation
e2e: emit-subject reads the whole status line - #12
Merged
Merged
Conversation
http-in writes its response in several segments, since TCP_NODELAY is on, and the test read once: it could get "HTTP/1.1 " alone and report an empty status. That turned master's CI red on a run where the PR had passed. The runtime answered 400 as it should. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_018wXgxT2UoFSZfqhAE1Tb5V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e/emit-subject.shread the raw response once.http-inwrites it in several segments, sinceTCP_NODELAYis on, so the test could getHTTP/1.1alone and report an empty status. That turnedcired on master at 44db9be after passing on #11. The runtime answered 400 as it should, so this changes the test only.It reads until the end of the status line. Six local runs in a row pass. This blocks the v0.4.0 tag.
🤖 Generated with Claude Code
https://claude.ai/code/session_018wXgxT2UoFSZfqhAE1Tb5V