Repository navigation
Drop h5py as a direct dependency - #121
Merged
Merged
Conversation
IMPSY never imports h5py. .h5 weights are read and written through Keras, which requires h5py itself, as does TensorFlow (h5py<3.15). The lock file is unchanged apart from its content hash. Refs #119 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016oUxTsghWZWfnCnnkKcuNv
4 of 6 tasks
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Removes the redundant direct h5py dependency while retaining it transitively through TensorFlow/Keras.
Changes:
- Removes
h5pyfrompyproject.toml. - Refreshes the Poetry lockfile content hash.
| File | Summary |
|---|---|
pyproject.toml |
Removes the direct dependency. |
poetry.lock |
Updates dependency metadata; retains transitive h5py. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPSY never imports
h5py..h5weight files are saved and loaded through Keras (save_weights/load_weights), and Keras requiresh5pyitself, as does TensorFlow 2.21 (h5py>=3.11.0,<3.15.0). The direct dependency was added as~3.10.0in May 2024, probably to pin a version for TensorFlow at the time.Installs don't change: h5py 3.14.0 still comes in through Keras and TensorFlow. The lock file only changes its content hash. All 229 tests pass locally.
Part of #119.
🤖 Generated with Claude Code
https://claude.ai/code/session_016oUxTsghWZWfnCnnkKcuNv