Repository navigation
Allow websockets 13 to 17 - #120
Merged
Merged
Conversation
The <14 cap came from a Poetry caret constraint (^12.0) carried through the PEP 621 migration, not a known incompatibility. IMPSY only uses the sync server API, which is unchanged. On Colab the cap downgraded websockets and broke preinstalled packages that need 14+. Adds a test that connects a real client, sends input (including an invalid message) and receives output. It passes on websockets 13.0 and 17.1. Refs #119 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016oUxTsghWZWfnCnnkKcuNv
4 of 6 tasks
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add reproducible WebSocket test coverage for the advertised 13.0 lower bound.
Review effort: Lite
Findings: None
What changed in this PR
This PR broadens WebSocket compatibility and adds real client/server round-trip coverage.
Changes:
- Supports
websockets13–17, locked at 17.1. - Adds integration tests for WebSocket input and output.
- Applies Black formatting.
| File | Description |
|---|---|
tests/test_impsio.py |
Adds client round-trip coverage and formatting. |
pyproject.toml |
Expands the WebSocket dependency range. |
poetry.lock |
Locks websockets at 17.1. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
websockets<14cap came fromwebsockets = "^12.0"(May 2024), carried through the PEP 621 migration. There was no known incompatibility behind it. IMPSY only uses the sync server API (websockets.sync.server.serve), which hasn't changed. On Colab the cap downgraded websockets to 13.1 and broke preinstalled packages that need 14+.websockets>=13.0,<18, locked at 17.1. Only websockets changes in the lock file.test_websocket_client_round_trip: the existing test never connected a client. This one connects a real client, sends a note and a CC (plus an invalid message, which should be skipped), checks the callback gets the right updates, and checks output reaches the client.tests/test_impsio.py.Part of the dependency review in #119.
🤖 Generated with Claude Code
https://claude.ai/code/session_016oUxTsghWZWfnCnnkKcuNv