Repository navigation
Install ALSA headers in the Colab notebook so python-rtmidi builds - #118
Merged
Merged
Conversation
python-rtmidi 1.5.8 has no Linux wheel for Python 3.13, so on Colab pip builds it from source, which fails without libasound2-dev. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016oUxTsghWZWfnCnnkKcuNv
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change addresses the reported Colab build issue without affecting non-Colab execution.
Review effort: Lite
Findings: None
What changed in this PR
Updates the Colab training notebook to install ALSA development headers so python-rtmidi can build on Python 3.13.
Changes:
- Detects Colab environments.
- Installs
libasound2-devbefore IMPSY. - Preserves non-Colab installation behavior.
| File | Description |
|---|---|
notebooks/impsy_training.ipynb |
Adds conditional ALSA header installation for Colab. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colab now runs Python 3.13, and python-rtmidi 1.5.8 has no Linux wheel for 3.13, so
pip install impsyfailed while building it from source. The install cell now installslibasound2-devfirst when running in Colab. Tested in Colab: install and training both work.The underlying problem is tracked in #117.
🤖 Generated with Claude Code
https://claude.ai/code/session_016oUxTsghWZWfnCnnkKcuNv