[simd.math] Fix various indexing problems#9201
Open
eisenwave wants to merge 1 commit into
Open
Conversation
1. There was indexing of simd::riemann_zeta without any declaration in the code block below. 2. Indexing for simd::remquo was missing. 3. Various declaration blocks were overly large for out-of-line indexing. For consistency, all blocks declaring multiple functions were converted to inline indexing.
mattkretz
reviewed
Jul 17, 2026
mattkretz
left a comment
Member
There was a problem hiding this comment.
Looks good from what I can see on my phone (on vacation).
Contributor
|
You're taking a vacation, in the moment where we need to index zeta functions?! |
Contributor
|
@eisenwave could you run a visual diffpdf before/after? |
Member
Author
no difference |
Contributor
|
Wait, how can there be no difference if we were previously indexing something that didn't exist? Wouldn't that have shown up erroneously in the index? |
Contributor
|
Oh, you've restricted the page numbers. Can you run the full diff, and show where the index starts to differ? |
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #9200
simd::riemann_zetawithout any declaration in the code block below.simd::remquowas missing.\indexlibraryglobalto\libglobal#9163 If you look at the PDF, you will find that several of the code blocks in [simd.math] span multiple pages, so the library index ends up pointing to the wrong page, sometimes off by multiple pages.