Skip to content

[simd.math] Fix various indexing problems#9201

Open
eisenwave wants to merge 1 commit into
cplusplus:mainfrom
eisenwave:simd-math-indexing
Open

[simd.math] Fix various indexing problems#9201
eisenwave wants to merge 1 commit into
cplusplus:mainfrom
eisenwave:simd-math-indexing

Conversation

@eisenwave

@eisenwave eisenwave commented Jul 17, 2026

Copy link
Copy Markdown
Member

Fixes #9200

  1. There was indexing of simd::riemann_zeta without any declaration in the code block below.
  2. Indexing for simd::remquo was missing.
  3. Various declaration blocks were overly large for out-of-line indexing. For consistency, all blocks declaring multiple functions were converted to inline indexing. This change is in the same style as [cmath.syn] Convert uses of \indexlibraryglobal to \libglobal #9163 If you look at the PDF, you will find that several of the code blocks in [simd.math] span multiple pages, so the library index ends up pointing to the wrong page, sometimes off by multiple pages.

1. There was indexing of simd::riemann_zeta without any declaration in the code block below.
2. Indexing for simd::remquo was missing.
3. Various declaration blocks were overly large for out-of-line indexing. For consistency, all blocks declaring multiple functions were converted to inline indexing.
@eisenwave eisenwave added the P2-Bug Presentational errors and omissions label Jul 17, 2026
@tkoeppe
tkoeppe requested a review from mattkretz July 17, 2026 16:35

@mattkretz mattkretz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can see on my phone (on vacation).

@tkoeppe

tkoeppe commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

You're taking a vacation, in the moment where we need to index zeta functions?!

@tkoeppe

tkoeppe commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@eisenwave could you run a visual diffpdf before/after?

@eisenwave

Copy link
Copy Markdown
Member Author

@eisenwave could you run a visual diffpdf before/after?

grafik

no difference

@tkoeppe

tkoeppe commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Wait, how can there be no difference if we were previously indexing something that didn't exist? Wouldn't that have shown up erroneously in the index?

@tkoeppe

tkoeppe commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Oh, you've restricted the page numbers. Can you run the full diff, and show where the index starts to differ?

@eisenwave

eisenwave commented Jul 17, 2026

Copy link
Copy Markdown
Member Author
grafik

Just kidding; I need to rerun some stuff.

@eisenwave

eisenwave commented Jul 17, 2026

Copy link
Copy Markdown
Member Author
grafik

The first index difference is for simd::beta, which got shifted from 1928 to 1929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2-Bug Presentational errors and omissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[simd.math] Stray indexing of riemann_zeta

3 participants