Repository navigation
land: test-hooks-feature - #1409
Merged
Merged
Conversation
Remove the self dev-dependency so lib-only test builds no longer wait for a second library compilation. Keep unit launcher hooks under cfg(test), require test-hooks in integration/rest, and opt integration builders into the feature explicitly. The storm workflow assertion intentionally changes from forbidding all features to requiring test-hooks on all three commands while continuing to forbid test-timing-hooks. Release manifests remain opt-in and the release-feature guard tests both test-only features. Co-authored-by: alfonso-aft <[email protected]>
Keep --no-fail-fast immediately after nextest run so the existing workflow contract assertion remains valid while explicitly enabling test-hooks. Verified: all 18 default test harnesses compile with test-hooks; plain --no-run fails with the intended compile_error. Conformance 38 passed, bridge/storm samples 1 each, Windows GNU lib/tests check passed. Workflow/archive/storm/gate Python checks 65/4/4/9 passed; Windows planner 3 checks; release guard 9 manifests and 1 positive/6 negative fixtures passed. Mac timings and raw artifacts are retained in the uncommitted internal investigation report. Co-authored-by: alfonso-aft <[email protected]>
Co-authored-by: alfonso-aft <[email protected]>
Co-authored-by: alfonso-aft <[email protected]>
…has its own Co-authored-by: alfonso-aft <[email protected]>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
…ecked without The Windows deny-warnings and MSRV checks ran cargo check --all-targets without the test-hooks feature, so the integration and rest suites refused to compile in the merge queue (those jobs don't run on pull requests). Each step now checks the library and binaries as shipped, then every target with test-hooks. The Windows step checks each command's exit code, since pwsh carries on past a failing native command. Two fixture READMEs had the same gap in their regeneration commands. Co-authored-by: alfonso-aft <[email protected]>
The CI archives build every test target with test-hooks, but the inventory proof listed lib and bin tests and doctests without it, so on Windows it compiled a second copy of the library and its test binary (about 8 extra minutes) and pushed the test-archive job past its 25-minute limit. Listing with the same features reuses the archive's build. Co-authored-by: alfonso-aft <[email protected]>
…shim tests and cost gate so they reuse the archive build Co-authored-by: alfonso-aft <[email protected]>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 8, 2026
…timing-hooks Co-authored-by: alfonso-aft <[email protected]>
… runners Co-authored-by: alfonso-aft <[email protected]>
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted agent delivery; branch-keyed search descriptor included.
Summary by cubic
Makes integration test hooks explicit by introducing a single
test-hooksCargo feature behindagent-file-tools, replacing the two priortest-sandbox-launcherandtest-conformance-result-inputsfeatures and removing the self dev-dependency that caused lib-only test builds to compile the library twice. Integration and rest test harnesses now fail at compile time instead of silently skipping when the feature is omitted. CI compile checks now verify the shipped library and binaries withouttest-hooks, then all targets with it (including the Windows conformance check), so merge-queue builds stay green. The test-inventory proof now lists lib, bin, and doctest targets withtest-hooksto match the CI archive build, and the macOS backtrace probe, inventory listings, gh-shim tests, and cost gate passtest-hooksthe same way, so these jobs reuse the archive build instead of compiling a second library copy that pushed a Windows archive job past its time limit. The background-task test's two waits were raised from 10 to 30 seconds so loaded Windows runners don't exceed the old bound.Migration
--features test-hooksto anycargo test/cargo nextestcommand that targets the integration or rest suites; lib-only test commands need no change.cargo test --features test-hooks -p agent-file-toolsfor the full suite. Production and release builds must never enable the feature, andscripts/check-secret-test-fake.shnow guards bothtest-hooksandsecret-test-fakeequally.Written for commit 2fb90b9. Summary will update on new commits.