Repository navigation
Remove unsourced catalog reviews and show books without ratings - #143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled catalog presents unsourced static copy as reader ratings and reviews. Remove those aggregates and 21 review texts from the nine older entries; all twelve books now use rating = 0, reviewCount = 0 and reviews = {}. Featured cards, library rows and detail facts show “No ratings yet” instead of a zero-star score. Supplied nonzero ratings and review text still render normally.
Provenance audit: all nine older entries and their reviews first appear together in c055005 (examples/adventure-arena/Catalog.lua). Its header attributes the content to “AdventureArena e7805e87”, but that upstream source is not available in the checked repository or discoverable account repository search. No reader submission, source URLs, attribution records or review collection service was found in the app. These are therefore unverified static/demo-style data, not proven reader feedback; this change does not claim their fabrication is conclusively established. No verified reader reviews were identified or removed. PR #142 already uses honest empty metadata for its three books.
Regression coverage audits every bundled entry, explicitly counts all six Arena Originals, renders every book through the three affected templates, and checks rated/reviewed synthetic fixtures still display normally. Removes old tests that pinned unsourced counts as source truth.
Validation: 395 assertions passed across adventure_arena_ratings, adventure_arena_model, adventure_arena_library and adventure_arena_new_books using Lua 5.4 (Lupa); AppKitNative stubbed only for TestKit loading. git diff --check passes. Native Apple UI screenshot/resize/light-dark QA is unavailable on this Linux host; no native visual verification is claimed.