You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci/tmt-tests: run build and test in the same fedora:latest container - #1182
This is to avoid an issue where the binary is built in an environment with one version of a system library (e.g. openssl 3) and then attempted to be run in an environment without that same version of the system library (e.g. system only has openssl 4).
Encountered after the recent Fedora 45 release, since that moves to openssl 4, and Ubuntu 24 (which we recently pinned) remains on openssl 3.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
No actionable comments were generated in the recent review.
Walkthrough
The TMT test job now runs in a Fedora container. It installs dependencies with dnf and always uses safe local provisioning. The optional source build remains conditional.
Changes: TMT workflow environment
Layer / File(s)
Summary
Configure and run TMT .github/workflows/tmt-tests.yml
The job runs in fedora:latest and installs its build and test tools with dnf. TMT now uses --feeling-safe and local provisioning. The conditional source build remains.
coreos/bootupd#1179: Changes the same job's runner environment and addresses a related TMT failure.
Suggested reviewers:c4rt0
Merge Risk: Minimal · up to 0e2df
The Fedora-container workflow is ready for normal checks; no concrete blocker remains in the reviewed changes.
Pre-merge checks: 6
Check name
Status
Explanation
Title check
The title "ci/tmt-tests: run build and test in the same fedora:latest container" describes the main change: the tmt-tests job now runs in a fedora:latest container. It follows the 'subsystem: descript…
Description check
The description explains the reason for the change. Building in one environment with one OpenSSL version and running in another can fail. It also gives context: Fedora 45 moves to OpenSSL 4, while the…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Commit Message Convention
The PR has one non-merge commit: ci/tmt-tests: run build and test in the same fedora:latest container. It uses a valid subsystem prefix, starts the description with the lowercase imperative verb `ru…
Full details: Title check
Explanation
The title "ci/tmt-tests: run build and test in the same fedora:latest container" describes the main change: the tmt-tests job now runs in a fedora:latest container. It follows the 'subsystem: description' pattern with a lowercase description and no trailing period. It does not fully match the required format, which asks for an imperative mood. The title uses the imperative 'run', so that requirement is met. The title also names the container change, which is the core of the diff.
Full details: Description check
Explanation
The description explains the reason for the change. Building in one environment with one OpenSSL version and running in another can fail. It also gives context: Fedora 45 moves to OpenSSL 4, while the pinned Ubuntu 24 stays on OpenSSL 3. The description relates directly to the workflow change.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Full details: Commit Message Convention
Explanation
The PR has one non-merge commit: ci/tmt-tests: run build and test in the same fedora:latest container. It uses a valid subsystem prefix, starts the description with the lowercase imperative verb run, and has no trailing period.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 1a0e1a1 and 0e2dfa7.
Files selected for processing: 1
.github/workflows/tmt-tests.yml
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This is to avoid an issue where the binary is built in an environment
with one version of a system library (e.g. openssl 3) and then attempted
to be run in an environment without that same version of the system
library (e.g. system only has openssl 4).
Encountered after the recent Fedora 45 release, since that moves to
openssl 4, and Ubuntu 24 (which we recently pinned) remains on openssl
3.
This is to avoid an issue where the binary is built in an environment
with one version of a system library (e.g. openssl 3) and then attempted
to be run in an environment without that same version of the system
library (e.g. system only has openssl 4).
Encountered after the recent Fedora 45 release, since that moves to
openssl 4, and Ubuntu 24 (which we recently pinned) remains on openssl
3.
See coreos/bootupd#1182, which this change is
copying
This is to avoid an issue where the binary is built in an environment
with one version of a system library (e.g. openssl 3) and then attempted
to be run in an environment without that same version of the system
library (e.g. system only has openssl 4).
Encountered after the recent Fedora 45 release, since that moves to
openssl 4, and Ubuntu 24 (which we recently pinned) remains on openssl
3.
See coreos/bootupd#1182, which this change is
copying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This is to avoid an issue where the binary is built in an environment with one version of a system library (e.g. openssl 3) and then attempted to be run in an environment without that same version of the system library (e.g. system only has openssl 4).
Encountered after the recent Fedora 45 release, since that moves to openssl 4, and Ubuntu 24 (which we recently pinned) remains on openssl 3.
e.g. #1181 (comment)