Repository navigation
Windows portability: locking, temp dirs, shell quoting, paths and permission tests - #887
Merged
Merged
Conversation
Slice-reopen: keep runtime roots stable when child processes inherit a Windows temporary directory.
Slice-reopen: use Windows byte-range locks when flock is unavailable.
Slice-reopen: generate cmd.exe-compatible command lines.
Slice-reopen: resolve python3 producer commands on Windows.
Slice-reopen: refresh file sizes and report repository paths consistently.
Slice-reopen: verify the final progress observation and its deterministic regression before the pre-push release lane.
Slice-reopen: focused regression repair; release lane is run by the lead.
Slice-reopen: focused race repair with loaded repeat proof; full release lane belongs to the lead.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
charness did not run on Windows hosts (the ceal team's Windows seats). Each seat carried a local patch that had to be reapplied on every charness update.
What changes
Windows portability fixes:
fcntl(Windows has none).cmd.exerejects.Fixes found while running the full release lane on this branch:
Verification
./scripts/run-quality.sh --full --read-only --releasepassed at d034937: 90 passed, 0 failed (4 opt-in phases not run). The pre-push hook ran the same lane on push.