Conversation
A local pull request only records the graded submission. The prompt and the exit pointer were telling the other agent to fetch origin/<peer>, which does not exist on their remote. Co-authored-by: Cursor <[email protected]>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing peer-exit tests appear incompatible with the new default behavior and must be updated before merging.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates collaboration prompts and peer-work pointers to avoid inaccessible peer branches when shared Git is disabled.
Changes:
- Gates shared-branch guidance on
git_enabled. - Clarifies local pull-request submission behavior.
- Adds peer-visibility regression tests.
| File | Summary |
|---|---|
tests/agents/mini_swe_agent_v2/test_peer_visibility.py |
Adds prompt and peer-pointer visibility tests. |
src/cooperbench/agents/mini_swe_agent_v2/config/coop.yaml |
Makes collaboration guidance conditional on shared Git. |
src/cooperbench/agents/mini_swe_agent_v2/agents/default.py |
Avoids suggesting inaccessible peer branches. Existing peer-exit fixtures require updates for the changed default behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

When shared Git is disabled, each agent's
originis a private submission remote. The coop prompt and peer-exit notice previously told agents to fetchorigin/<peer>anyway. A messaging-on, shared-Git-off Click run followed that guidance and failed withunknown revision.This change names a peer branch only when shared Git is enabled and the peer published it. Prompts distinguish the local graded submission from a branch the colleague can read. All four Git × messaging configurations retain
git push/gh pr createsubmission guidance while recommending only the enabled communication channels. Theghshim's help and conflict warning no longer unconditionally recommend messaging.The existing peer-exit fixtures now explicitly model a shared remote, preserving their published/unpublished recovery-path coverage. New regressions cover prompt rendering for all four configurations, no messaging-off peer notices, and the private-remote pointer. Existing real-Git shim tests also verify the revised guidance. The task, grading, and messaging protocol are unchanged.
Validation on macOS / Python 3.13.13:
pytest tests/ -q: 457 passed, 63 skipped. Redis-dependent unit tests used a temporary loopbackfakeredis.TcpFakeServerviaTEST_REDIS_URL; this validates the connector path against fake Redis, not a live Redis service. Modal/Docker/GCP integration tests remain skipped by default.ruff check src/cooperbench/,ruff format --check src/cooperbench/, andmypy src/cooperbench/: pass.sh -nfor the shim, andgit diff --check: pass.No new live model rollout was run for this prompt correction. Hosted CI has not reported checks for this PR yet.
Made with Cursor