Add HTTP timeouts to all Net::HTTP requests - #57
Closed
bellisabell wants to merge 1 commit into
Closed
Conversation
Security fix: All Net::HTTP requests now have open_timeout=5 and read_timeout=10 to prevent hanging on unresponsive external services. Files updated: - app/models/domain.rb (render_service_request and liveness_check) - app/jobs/post_in_admin_chat_job.rb - app/jobs/subscribe_to_contraption_ghost_job.rb Closes #21
Contributor
|
Superseded by #77, which adds connection/read/write timeout budgets while preserving newer domain-verification behavior and tests network configuration. The replacement passes all four current-head CI checks (tests and Docker smoke on push and PR), plus the local SOLO and MULTIUSER suites (62 tests / 259 assertions each). Closing this older implementation to keep one tested review path. Any linked issue remains open until the replacement is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security fix: All Net::HTTP requests now have timeouts to prevent hanging on unresponsive external services.
Changes
Files updated:
app/models/domain.rb-render_service_requestandliveness_checkmethodsapp/jobs/post_in_admin_chat_job.rb- Admin chat webhookapp/jobs/subscribe_to_contraption_ghost_job.rb- Newsletter subscription APICloses #21