Add Google One Tap sign-in to homepage - #12
Closed
bellisabell wants to merge 2 commits into
Closed
Conversation
- Add google-id-token gem for JWT verification - Create GoogleOneTapController to handle callback - Add route for /auth/google_one_tap/callback - Add One Tap script and config to homepage (multiuser mode only) One Tap shows a popup for users already signed into Google, allowing one-click sign-up/sign-in. Falls back gracefully if user dismisses or isn't signed into Google.
bellisabell
force-pushed
the
bell/google-one-tap
branch
from
February 9, 2026 02:16
56e7233 to
9061325
Compare
Contributor
|
Closing this untested implementation after a fresh review against current main. The callback disables Rails CSRF without validating Google's double-submit CSRF token, returns existing accounts directly (bypassing the current OAuth restriction on administrator accounts), and signs in without checking active/locked state. The callback route also remains available outside multiuser mode. Existing Google OAuth remains the supported signup flow. A future One Tap implementation should share account policy and include CSRF, token, locked/admin-account, and mode regression tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Google One Tap authentication to the marketing homepage for frictionless sign-up.
What it does
Changes
google-id-tokengem for JWT verificationGoogleOneTapControllerto handle the callbackPOST /auth/google_one_tap/callbackNotes