container: tell the hook type and number on hook failure - #2248
Merged
Merged
Conversation
When a hook fails, crun says error executing hook `/bin/false` (exit code: 1) which does not tell what hook it was, and a container can have many. Add the hook type and its number (starting from 0, like runc does) to the message, making it error running createRuntime hook #1: `/bin/false` (exit code: 1) which is also similar to what runc says, as some tools and tests (e.g. "runc create [hook fails]" runc integration test) check for it. Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a hook fails, crun says
which does not tell what hook it was, and a container can have many.
Add the hook type and its number (starting from 0, like runc does) to the message, making it
which is also similar to what runc says, as some tools and tests check for it.
Found by the runc integration tests (see #2238): "runc create [hook fails]", "runc create [second createRuntime hook fails]", "runc run [hook fails]".