Skip to content

refactor(metaschema-modules): define events_module.record_error inline, drop the alteration #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
Sep 7, 2026
Merged

refactor(metaschema-modules): define events_module.record_error inline, drop the alteration #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ...y/schemas/metaschema_modules_public/tables/events_module/alterations/add_record_error.sql
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions ...etaschema-modules/deploy/schemas/metaschema_modules_public/tables/events_module/table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ CREATE TABLE metaschema_modules_public.events_module (
achievement_rewards_table_name text NOT NULL DEFAULT '',

record_event text NOT NULL DEFAULT '',
record_error text NOT NULL DEFAULT '',
remove_event text NOT NULL DEFAULT '',
tg_event text NOT NULL DEFAULT '',
tg_event_toggle text NOT NULL DEFAULT '',
Expand Down
1 change: 0 additions & 1 deletion packages/metaschema-modules/pgpm.plan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,3 @@ schemas/metaschema_modules_public/tables/image_module/table [schemas/metaschema_
schemas/metaschema_modules_public/tables/repository_module/table [schemas/metaschema_modules_public/schema] 2026-08-15T01:00:00Z devin <[email protected]> # add repository_module config table (repositories, events, workflows, builds, local change requests)
schemas/metaschema_modules_public/tables/machine_module/table [schemas/metaschema_modules_public/schema] 2026-08-15T02:00:00Z devin <[email protected]> # add machine_module config table (enrolled machines, sessions, command ledger)
schemas/metaschema_modules_public/tables/cluster_module/table [schemas/metaschema_modules_public/schema] 2026-08-17T00:00:00Z devin <[email protected]> # add cluster_module config table (fleet catalog: clusters, database servers, physical databases, placements)
schemas/metaschema_modules_public/tables/events_module/alterations/add_record_error [schemas/metaschema_modules_public/tables/events_module/table] 2026-09-06T02:30:00Z devin <[email protected]> # add record_error: the generated function that records a refused operation under its error code as the event name
8 changes: 0 additions & 8 deletions ...t/schemas/metaschema_modules_public/tables/events_module/alterations/add_record_error.sql
View file
Open in desktop

This file was deleted.

Binary file modified packages/metaschema-modules/sql/metaschema-modules--0.44.1.bundle.tar.gz
View file
Open in desktop
Binary file not shown.
8 changes: 2 additions & 6 deletions packages/metaschema-modules/sql/metaschema-modules--0.44.1.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ CREATE TABLE metaschema_modules_public.events_module (
achievement_rewards_table_id uuid NOT NULL DEFAULT uuid_nil(),
achievement_rewards_table_name text NOT NULL DEFAULT '',
record_event text NOT NULL DEFAULT '',
record_error text NOT NULL DEFAULT '',

@tenki-reviewer tenki-reviewer Bot Sep 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 bug · medium

Mutate released v0.44.1 artifact without version bump

The released v0.44.1 (tag) shipped sql/metaschema-modules--0.44.1.sql ending in ALTER TABLE ... ADD COLUMN record_error, but this PR regenerates that same 0.44.1 artifact with record_error folded into the CREATE TABLE (sql/metaschema-modules--0.44.1.sql:365) while package.json and metaschema-modules.control still declare 0.44.1. The same version now maps to two different install artifacts with different sha256 digests, breaking byte reproducibility and version immutability for consumers who pinned or installed v0.44.1. The installed schema is functionally identical, so there is no data loss, but the change should ship as a new version rather than mutating the released artifact.

📋 Prompt for AI Agents

In packages/metaschema-modules, bump the version from 0.44.1 to 0.44.2 in package.json (line 3) and metaschema-modules.control (default_version), and regenerate sql/metaschema-modules--0.44.2.sql plus its .bundle.tar.gz from deploy/ + pgpm.plan, leaving the released 0.44.1 artifact untouched so consumers who installed v0.44.1 keep a stable, byte-reproducible artifact.

remove_event text NOT NULL DEFAULT '',
tg_event text NOT NULL DEFAULT '',
tg_event_toggle text NOT NULL DEFAULT '',
Expand Down Expand Up @@ -6557,9 +6558,4 @@ COMMENT ON COLUMN metaschema_modules_public.cluster_module.database_servers_tabl

COMMENT ON COLUMN metaschema_modules_public.cluster_module.physical_databases_table_id IS '@module_table';

COMMENT ON COLUMN metaschema_modules_public.cluster_module.database_placements_table_id IS '@module_table';

ALTER TABLE metaschema_modules_public.events_module
ADD COLUMN record_error text
NOT NULL
DEFAULT '';
COMMENT ON COLUMN metaschema_modules_public.cluster_module.database_placements_table_id IS '@module_table';
7 changes: 0 additions & 7 deletions ...y/schemas/metaschema_modules_public/tables/events_module/alterations/add_record_error.sql
View file
Open in desktop

This file was deleted.

Loading